Skip to content

Commit 994fccf

Browse files
committed
Revert "Remove PYTHON_LIBRARY and PYTHON_INCLUDE_DIR force"
This reverts commit c5f9d96.
1 parent 1470ed5 commit 994fccf

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,17 @@ set(PYTHON_VERSION_RESET "${PYTHON_VERSION}")
8989
set(PYTHON_EXECUTABLE_RESET "${PYTHON_EXECUTABLE}")
9090
set(PYTHON_LIBRARIES_RESET "${PYTHON_LIBRARIES}")
9191
set(PYTHON_INCLUDE_DIRS_RESET "${PYTHON_INCLUDE_DIRS}")
92+
set(PYTHON_LIBRARY_RESET "${PYTHON_LIBRARY}")
93+
set(PYTHON_INCLUDE_DIR_RESET "${PYTHON_INCLUDE_DIR}")
9294

9395
# Change PYTHON_* vars before pybind11 find_package
9496
# to be sure that pybind11 relies on the right Python version
9597
set(PYTHON_VERSION "${Python_VERSION}" CACHE STRING "" FORCE)
9698
set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}" CACHE FILEPATH "" FORCE)
9799
set(PYTHON_LIBRARIES "${Python_LIBRARIES}" CACHE STRING "" FORCE)
98100
set(PYTHON_INCLUDE_DIRS "${Python_INCLUDE_DIRS}" CACHE STRING "" FORCE)
101+
set(PYTHON_LIBRARY "${Python_LIBRARY}" CACHE INTERNAL "" FORCE)
102+
set(PYTHON_INCLUDE_DIR "${Python_INCLUDE_DIR}" CACHE INTERNAL "" FORCE)
99103

100104
# Set the minimum pybind11 version to 2.3 (before that the pybind11::embed target did not exist)
101105
find_package(pybind11 2.3 CONFIG QUIET REQUIRED)
@@ -105,6 +109,8 @@ set(PYTHON_VERSION "${PYTHON_VERSION_RESET}" CACHE STRING "" FORCE)
105109
set(PYTHON_EXECUTABLE "${PYTHON_EXECUTABLE_RESET}" CACHE FILEPATH "" FORCE)
106110
set(PYTHON_LIBRARIES "${PYTHON_LIBRARIES_RESET}" CACHE STRING "" FORCE)
107111
set(PYTHON_INCLUDE_DIRS "${PYTHON_INCLUDE_DIRS_RESET}" CACHE STRING "" FORCE)
112+
set(PYTHON_LIBRARY "${PYTHON_LIBRARY_RESET}" CACHE INTERNAL "" FORCE)
113+
set(PYTHON_INCLUDE_DIR "${PYTHON_INCLUDE_DIR_RESET}" CACHE INTERNAL "" FORCE)
108114

109115
set(SP3_PYTHON_PACKAGES_DIRECTORY
110116
"python3/site-packages"

SofaPython3Config.cmake.in

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,17 @@ set(PYTHON_VERSION_RESET "${PYTHON_VERSION}")
1717
set(PYTHON_EXECUTABLE_RESET "${PYTHON_EXECUTABLE}")
1818
set(PYTHON_LIBRARIES_RESET "${PYTHON_LIBRARIES}")
1919
set(PYTHON_INCLUDE_DIRS_RESET "${PYTHON_INCLUDE_DIRS}")
20+
set(PYTHON_LIBRARY_RESET "${PYTHON_LIBRARY}")
21+
set(PYTHON_INCLUDE_DIR_RESET "${PYTHON_INCLUDE_DIR}")
2022

2123
# Change PYTHON_* vars before pybind11 find_package
2224
# to be sure that pybind11 relies on the right Python version
2325
set(PYTHON_VERSION "${Python_VERSION}" CACHE STRING "" FORCE)
2426
set(PYTHON_EXECUTABLE "${Python_EXECUTABLE}" CACHE FILEPATH "" FORCE)
2527
set(PYTHON_LIBRARIES "${Python_LIBRARIES}" CACHE STRING "" FORCE)
2628
set(PYTHON_INCLUDE_DIRS "${Python_INCLUDE_DIRS}" CACHE STRING "" FORCE)
29+
set(PYTHON_LIBRARY "${Python_LIBRARY}" CACHE INTERNAL "" FORCE)
30+
set(PYTHON_INCLUDE_DIR "${Python_INCLUDE_DIR}" CACHE INTERNAL "" FORCE)
2731

2832
# Set the minimum pybind11 version to 2.3 (before that the pybind11::embed target did not exist)
2933
find_package(pybind11 2.3 CONFIG QUIET REQUIRED)
@@ -33,6 +37,8 @@ set(PYTHON_VERSION "${PYTHON_VERSION_RESET}" CACHE STRING "" FORCE)
3337
set(PYTHON_EXECUTABLE "${PYTHON_EXECUTABLE_RESET}" CACHE FILEPATH "" FORCE)
3438
set(PYTHON_LIBRARIES "${PYTHON_LIBRARIES_RESET}" CACHE STRING "" FORCE)
3539
set(PYTHON_INCLUDE_DIRS "${PYTHON_INCLUDE_DIRS_RESET}" CACHE STRING "" FORCE)
40+
set(PYTHON_LIBRARY "${PYTHON_LIBRARY_RESET}" CACHE INTERNAL "" FORCE)
41+
set(PYTHON_INCLUDE_DIR "${PYTHON_INCLUDE_DIR_RESET}" CACHE INTERNAL "" FORCE)
3642

3743
if(NOT SofaPython3_FIND_COMPONENTS)
3844
set(SofaPython3_FIND_COMPONENTS Plugin Bindings)

0 commit comments

Comments
 (0)