ADD: Prefab states and error msgs updated on reInit

Author: marques-bruno

Plugin/src/SofaPython3/Prefab.cpp

@@ -21,9 +21,9 @@ using sofa::core::objectmodel::Event;
 
 void Prefab::init()
 {
-    std::cout << "prefab::init" << std::endl;
     reinit();
     Inherit1::init(sofa::core::ExecParams::defaultInstance());
+    m_is_initialized = true;
 }
 
 void PrefabFileEventListener::fileHasChanged(const std::string &filename)
@@ -44,21 +44,16 @@ void PrefabFileEventListener::fileHasChanged(const std::string &filename)
 
 void Prefab::reinit()
 {
-    std::cout << "prefab::reinit" << std::endl;
     clearLoggedMessages();
 
     /// remove everything in the node.
     execute<sofa::simulation::DeleteVisitor>(sofa::core::ExecParams::defaultInstance());
-    std::cout << "prefab::doReInit" << std::endl;
+
     doReInit();
 
-    std::cout << "simulation->initNode" << std::endl;
     /// Beurk beurk beurk
     sofa::simulation::getSimulation()->initNode(this);
-    std::cout << "VisualInitVisitor" << std::endl;
     execute<VisualInitVisitor>(nullptr);
-
-    d_componentState.setValue(sofa::core::objectmodel::ComponentState::Valid);
 }
 
 void Prefab::doReInit()
@@ -83,19 +78,18 @@ void Prefab::addPrefabParameter(const std::string& name, const std::string& help
     if(!findData(name) && !findLink(name))
     {
         sofa::core::objectmodel::BaseData* data = sofapython3::addData(py::cast(this), name, py::none(), defaultValue, help, "Prefab's properties", type);
+        data->setRequired(true);
         m_datacallback.addInputs({data});
     }
 }
 
 void Prefab::setSourceTracking(const std::string& filename)
 {
-    std::cout << "Activating source tracking to " << filename << std::endl;
     FileMonitor::addFile(filename, &m_filelistener);
 }
 
 void Prefab::breakPrefab()
 {
-    std::cout << "Breaking prefab" << std::endl;
     FileMonitor::removeListener(&m_filelistener);
     for (auto& data : this->getDataFields())
         if (data->getGroup() == "Prefab's properties")

Plugin/src/SofaPython3/Prefab.h

@@ -48,5 +48,6 @@ class SOFAPYTHON3_API Prefab : public BasePrefab
 
     PrefabFileEventListener m_filelistener;
     DataCallback m_datacallback;
+    bool m_is_initialized {false};
 };
 }  // namespace sofapython3

bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_Prefab.cpp

@@ -68,10 +68,17 @@ class Prefab_Trampoline : public Prefab, public PythonTrampoline
 
 void Prefab_Trampoline::doReInit()
 {
+    if (!m_is_initialized) {
+        this->d_componentState.setValue(sofa::core::objectmodel::ComponentState::Loading);
+        msg_warning(this) << "Prefab instantiated. Check for required prefab parameters to fully populate";
+        return;
+    }
     try{
+        this->d_componentState.setValue(sofa::core::objectmodel::ComponentState::Valid);
         PYBIND11_OVERLOAD(void, Prefab, doReInit, );
     } catch (std::exception& e)
     {
+        this->d_componentState.setValue(sofa::core::objectmodel::ComponentState::Invalid);
         msg_error(this) << e.what();
     }
 }