Comment color does not match screenshot

[codehearts]

I'm seeing a really low contrast for comments compared to the readme screenshot (my colors on the right). Looks like the other themes are using a color at 60% opacity, but the RGB value in the vim port is a little too light

[lovemecomputer]

thanks for tracking this! i'm actually working on a big update to soft era in VS Code, and am happy to trawl through a lot of these ports to check color values when that drops. (contrast for default text and comments are both addressed, so perhaps that could inform things here). but, i haven't used vim before so i'm glad you have your eyes on this!!

[codehearts]

Hey! I see there've been a lot of commits to the VS Code theme, do you think that's stable enough for the colors to be ported over to the other editors? I'd love to get the Vim theme up to date so I can use this as my default theme ☺️

[lovemecomputer]

@codehearts yea totally!! there may be some minor tweaks here and there as time goes on, but for the most part, i'm cosidering that major v1.0 VS Code release as stable!

edit: fyi there are some general changes to which colors are applied to what kind of elements, especially like, control element receiving a darker treatment to strongly visually identify the logical branching and execution flow. there may be some values that have transparency to get just the right tone. i'm super happy to provide some equivalent non-transparent hex values where needed! (i should do this to be available for all ports tbh. will think about how to post/communicate, but def feel free to ping me to ask for specific things if u run into something!)

[justwheel]

I noticed this too when I set it up for the first time. I have the same issue with comment color and line numbers with low contrast. I would appreciate this too if it could be improved. 🙂