refactor: Remove runBlockingAll from UI tests

- The `runBlockingAll` utility function has been removed from several UI test cases (`SignInTestCase`, `EditTitleAfterCreateTestCase`, `LocaleTestCase`, `EditTitleAfterSaveTestCase`).
- String resource fetching within tests now happens directly in the coroutine scope provided by `runTest`, simplifying the code.
- `DbTestEncryptor` has been updated to be a `suspend` function, removing the need for `runBlockingAll`.
- In `CustomActivityScenarioRule` for Android tests, the `beforeActivityLaunched` lambda is now a `suspend` function and is invoked within a `runBlocking` block, aligning with the removal of the custom blocking utility.

Author: softartdev

app/android/src/androidTest/java/com/softartdev/notedelight/ui/CustomActivityScenarioRule.kt

@@ -4,17 +4,18 @@ import android.app.Activity
 import androidx.activity.ComponentActivity
 import androidx.compose.ui.test.junit4.AndroidComposeTestRule
 import androidx.test.core.app.ActivityScenario
+import kotlinx.coroutines.runBlocking
 import org.junit.rules.ExternalResource
 
 inline fun <reified A : ComponentActivity> customAndroidComposeRule(
-    noinline beforeActivityLaunched: () -> Unit
+    noinline beforeActivityLaunched: suspend () -> Unit
 ): AndroidComposeTestRule<CustomActivityScenarioRule<A>, A> {
     return customAndroidComposeRule(A::class.java, beforeActivityLaunched)
 }
 
 fun <A : ComponentActivity> customAndroidComposeRule(
     activityClass: Class<A>,
-    beforeActivityLaunched: () -> Unit
+    beforeActivityLaunched: suspend () -> Unit
 ): AndroidComposeTestRule<CustomActivityScenarioRule<A>, A> = AndroidComposeTestRule(
     activityRule = CustomActivityScenarioRule(activityClass, beforeActivityLaunched),
     activityProvider = ::provideActivity
@@ -30,13 +31,13 @@ fun <A : Activity> provideActivity(customActivityScenarioRule: CustomActivitySce
 
 class CustomActivityScenarioRule<A : Activity>(
     private val activityClass: Class<A>,
-    private val beforeActivityLaunched: () -> Unit
+    private val beforeActivityLaunched: suspend () -> Unit
 ) : ExternalResource() {
 
     internal lateinit var scenario: ActivityScenario<A>
 
     override fun before() {
-        beforeActivityLaunched()
+        runBlocking { beforeActivityLaunched() }
         scenario = ActivityScenario.launch(activityClass)
     }
 

ui/test/src/commonMain/kotlin/com/softartdev/notedelight/DbTestEncryptor.kt

@@ -3,16 +3,15 @@ package com.softartdev.notedelight
 import co.touchlab.kermit.Logger
 import com.softartdev.notedelight.model.PlatformSQLiteState
 import com.softartdev.notedelight.repository.SafeRepo
-import com.softartdev.notedelight.util.runBlockingAll
 import kotlinx.coroutines.delay
 import org.koin.mp.KoinPlatform
 import kotlin.time.Duration.Companion.seconds
 
-object DbTestEncryptor : () -> Unit {
+object DbTestEncryptor : suspend () -> Unit {
     private val logger = Logger.withTag(this@DbTestEncryptor::class.simpleName.toString())
     const val PASSWORD = "password"
 
-    override fun invoke() = runBlockingAll {
+    override suspend fun invoke() {
         val safeRepo: SafeRepo by KoinPlatform.getKoin().inject()
         while (safeRepo.databaseState == PlatformSQLiteState.DOES_NOT_EXIST) {
             safeRepo.buildDbIfNeed()

ui/test/src/commonMain/kotlin/com/softartdev/notedelight/ui/cases/EditTitleAfterCreateTestCase.kt

@@ -10,7 +10,6 @@ import androidx.compose.ui.test.performTextInput
 import androidx.compose.ui.test.performTextReplacement
 import com.softartdev.notedelight.ui.BaseTestCase
 import com.softartdev.notedelight.ui.screen.MainTestScreen.Companion.noteItemTitleText
-import com.softartdev.notedelight.util.runBlockingAll
 import com.softartdev.notedelight.waitUntilDisplayed
 import kotlinx.coroutines.test.TestResult
 import kotlinx.coroutines.test.runTest
@@ -41,7 +40,7 @@ class EditTitleAfterCreateTestCase(
                     confirmDialogButtonSNI.performClick()
                 }
                 composeUiTest
-                    .onNodeWithContentDescription(label = runBlockingAll { getString(Res.string.enter_title) })
+                    .onNodeWithContentDescription(label = getString(Res.string.enter_title))
                     .assertDoesNotExist()
                 saveNoteMenuButtonSNI.performClick()
                 backButtonSNI.performClick()

ui/test/src/commonMain/kotlin/com/softartdev/notedelight/ui/cases/EditTitleAfterSaveTestCase.kt

@@ -10,7 +10,6 @@ import androidx.compose.ui.test.performTextInput
 import androidx.compose.ui.test.performTextReplacement
 import com.softartdev.notedelight.ui.BaseTestCase
 import com.softartdev.notedelight.ui.screen.MainTestScreen.Companion.noteItemTitleText
-import com.softartdev.notedelight.util.runBlockingAll
 import com.softartdev.notedelight.waitUntilDisplayed
 import kotlinx.coroutines.test.TestResult
 import kotlinx.coroutines.test.runTest
@@ -47,7 +46,7 @@ class EditTitleAfterSaveTestCase(
                     confirmDialogButtonSNI.performClick()
                 }
                 composeUiTest
-                    .onNodeWithContentDescription(label = runBlockingAll { getString(Res.string.enter_title) })
+                    .onNodeWithContentDescription(label = getString(Res.string.enter_title))
                     .assertDoesNotExist()
                 saveNoteMenuButtonSNI.performClick()
                 backButtonSNI.performClick()

ui/test/src/commonMain/kotlin/com/softartdev/notedelight/ui/cases/LocaleTestCase.kt

@@ -11,7 +11,6 @@ import com.softartdev.notedelight.ASSERT_WAIT_TIMEOUT_MILLIS
 import com.softartdev.notedelight.interactor.LocaleInteractor
 import com.softartdev.notedelight.model.LanguageEnum
 import com.softartdev.notedelight.ui.BaseTestCase
-import com.softartdev.notedelight.util.runBlockingAll
 import com.softartdev.notedelight.waitUntilDisplayed
 import com.softartdev.notedelight.waitUntilSelected
 import kotlinx.coroutines.test.TestResult
@@ -43,7 +42,7 @@ class LocaleTestCase(
                         confirmDialogButtonSNI.performClick()
                     }
                     composeUiTest.waitUntilDoesNotExist(
-                        matcher = hasText(runBlockingAll { getString(Res.string.choose_language) }),
+                        matcher = hasText(getString(Res.string.choose_language)),
                         timeoutMillis = ASSERT_WAIT_TIMEOUT_MILLIS,
                     )
                     assertEquals(languageEnum, localeInteractor.languageEnum)

ui/test/src/commonMain/kotlin/com/softartdev/notedelight/ui/cases/SignInTestCase.kt

@@ -12,7 +12,6 @@ import com.softartdev.notedelight.DbTestEncryptor
 import com.softartdev.notedelight.ui.BaseTestCase
 import com.softartdev.notedelight.waitAssert
 import com.softartdev.notedelight.waitUntilDisplayed
-import com.softartdev.notedelight.util.runBlockingAll
 import kotlinx.coroutines.test.TestResult
 import kotlinx.coroutines.test.runTest
 import notedelight.ui.shared.generated.resources.Res
@@ -31,21 +30,21 @@ class SignInTestCase(
             composeUiTest.waitUntilDisplayed("passwordField", blockSNI = ::passwordFieldSNI)
 
             passwordLabelSNI.assertIsDisplayed()
-                .assertTextEquals(runBlockingAll { getString(Res.string.enter_password) })
+                .assertTextEquals(getString(Res.string.enter_password))
 
             passwordVisibilitySNI.assertIsDisplayed()
                 .performClick()
 
             signInButtonSNI.performClick()
-            val emptyPassTitle = runBlockingAll { getString(Res.string.empty_password) }
+            val emptyPassTitle = getString(Res.string.empty_password)
             composeUiTest.waitAssert("password label has empty pass text") {
                 passwordLabelSNI.assertTextEquals(emptyPassTitle)
             }
             passwordFieldSNI.performTextReplacement(text = "incorrect password")
             closeSoftKeyboard()
             signInButtonSNI.performClick()
 
-            passwordLabelSNI.assertTextEquals(runBlockingAll { getString(Res.string.incorrect_password) })
+            passwordLabelSNI.assertTextEquals(getString(Res.string.incorrect_password))
 
             passwordFieldSNI.performTextReplacement(text = DbTestEncryptor.PASSWORD)
             closeSoftKeyboard()