refactor: Rename CheckEncryption action to updateSwitches

- Rename `SettingsAction.CheckEncryption` to a more descriptive `updateSwitches()` method in `SettingsViewModel`.
- The new `updateSwitches()` method is now called directly from the `SettingsScreen` when the lifecycle resumes.
- Remove the unused `CheckEncryption` data object from `SettingsAction`.
- Update the corresponding test case in `SettingsViewModelTest` to reflect this renaming.

Author: softartdev

core/presentation/src/androidHostTest/kotlin/com/softartdev/notedelight/presentation/settings/SettingsViewModelTest.kt

@@ -64,7 +64,7 @@ class SettingsViewModelTest {
         Mockito.`when`(mockLocaleInteractor.languageEnum).thenReturn(LanguageEnum.ENGLISH)
         settingsViewModel.stateFlow.test {
             assertFalse(awaitItem().loading)
-            settingsViewModel.onAction(SettingsAction.CheckEncryption)
+            settingsViewModel.updateSwitches()
             if (encryption) awaitItem().let { result: SecurityResult ->
                 assertFalse(result.loading)
                 assertTrue(result.encryption)

core/presentation/src/commonMain/kotlin/com/softartdev/notedelight/presentation/settings/SecurityResult.kt

@@ -18,7 +18,6 @@ sealed interface SettingsAction {
     data object NavBack : SettingsAction
     data object ChangeTheme : SettingsAction
     data object ChangeLanguage : SettingsAction
-    data object CheckEncryption : SettingsAction
     data class ChangeEncryption(val checked: Boolean) : SettingsAction
     data object ChangePassword : SettingsAction
     data object ShowCipherVersion : SettingsAction

core/presentation/src/commonMain/kotlin/com/softartdev/notedelight/presentation/settings/SettingsViewModel.kt

@@ -41,7 +41,6 @@ class SettingsViewModel(
         is SettingsAction.NavBack -> navBack()
         is SettingsAction.ChangeTheme -> changeTheme()
         is SettingsAction.ChangeLanguage -> changeLanguage()
-        is SettingsAction.CheckEncryption -> checkEncryption() //TODO use directly
         is SettingsAction.ChangeEncryption -> changeEncryption(action.checked)
         is SettingsAction.ChangePassword -> changePassword()
         is SettingsAction.ShowCipherVersion -> showCipherVersion()
@@ -50,22 +49,14 @@ class SettingsViewModel(
         is SettingsAction.RevealFileList -> revealFileList()
     }
 
-    private fun navBack() {
-        if (!router.popBackStack()) router.navigate(route = AppNavGraph.Splash)
-    }
-
-    private fun changeTheme() = router.navigate(route = AppNavGraph.ThemeDialog)
-
-    private fun changeLanguage() = router.navigate(route = AppNavGraph.LanguageDialog)
-
-    private fun checkEncryption() = viewModelScope.launch {
+    fun updateSwitches() = viewModelScope.launch {
         CountingIdlingRes.increment()
         mutableStateFlow.update(SecurityResult::showLoading)
         try {
             mutableStateFlow.update { result ->
                 result.copy(
                     encryption = dbIsEncrypted,
-                    language = localeInteractor.languageEnum //TODO move to separate function
+                    language = localeInteractor.languageEnum
                 )
             }
         } catch (e: Throwable) {
@@ -76,6 +67,14 @@ class SettingsViewModel(
         }
     }
 
+    private fun navBack() {
+        if (!router.popBackStack()) router.navigate(route = AppNavGraph.Splash)
+    }
+
+    private fun changeTheme() = router.navigate(route = AppNavGraph.ThemeDialog)
+
+    private fun changeLanguage() = router.navigate(route = AppNavGraph.LanguageDialog)
+
     private fun changeEncryption(checked: Boolean) = viewModelScope.launch {
         CountingIdlingRes.increment()
         mutableStateFlow.update(SecurityResult::showLoading)

ui/shared/src/commonMain/kotlin/com/softartdev/notedelight/ui/settings/SettingsScreen.kt

@@ -79,7 +79,7 @@ import org.jetbrains.compose.ui.tooling.preview.Preview
 fun SettingsScreen(settingsViewModel: SettingsViewModel) {
     val result: SecurityResult by settingsViewModel.stateFlow.collectAsState()
     LifecycleResumeEffect(key1 = settingsViewModel) {
-        settingsViewModel.onAction(SettingsAction.CheckEncryption)
+        settingsViewModel.updateSwitches()
         onPauseOrDispose {}
     }
     SettingsScreenBody(result, settingsViewModel::onAction)