refactor(test): Replace retry helpers with waitUntilDoesNotExist

- Remove the custom `retryUntil` and `retryUntilNotDisplayed` helper functions from `ext.kt`.
- Introduce a new `waitUntilNotExist` extension function for `ComposeUiTest` that uses the standard `waitUntilDoesNotExist` with a timeout.
- Update `SettingPasswordTestCase` to use `waitUntilNotExist` instead of a custom wait assertion (`waitAssert` with `assertIsNotDisplayed`) to check for a dialog's disappearance.

Author: softartdev

ui/test/src/commonMain/kotlin/com/softartdev/notedelight/ext.kt

@@ -6,31 +6,15 @@ import androidx.compose.ui.test.ComposeUiTest
 import androidx.compose.ui.test.ExperimentalTestApi
 import androidx.compose.ui.test.SemanticsNodeInteraction
 import androidx.compose.ui.test.assertIsDisplayed
-import androidx.compose.ui.test.assertIsNotDisplayed
 import androidx.compose.ui.test.assertIsSelectable
 import androidx.compose.ui.test.assertIsSelected
-import androidx.compose.ui.test.isNotDisplayed
+import androidx.compose.ui.test.hasTestTag
+import androidx.compose.ui.test.waitUntilDoesNotExist
 import co.touchlab.kermit.Logger
 
 const val ASSERT_WAIT_TIMEOUT_MILLIS: Long = 5_000
 const val MAX_RETRY_ATTEMPTS = 100
 
-inline fun retryUntil(
-    description: String,
-    action: () -> Unit,
-    assertion: () -> SemanticsNodeInteraction,
-): SemanticsNodeInteraction {
-    var asserted: Boolean = runCatching(assertion).isSuccess
-    var retries = 0
-    while (!asserted && retries < MAX_RETRY_ATTEMPTS) {
-        retries++
-        runCatching(action)
-        asserted = runCatching(assertion).isSuccess
-    }
-    Logger.withTag("ℹ️retryUntil").i { "After $retries retries is $asserted for $description" }
-    return assertion.invoke()
-}
-
 inline fun retryUntilDisplayed(
     description: String,
     action: () -> Unit,
@@ -47,22 +31,6 @@ inline fun retryUntilDisplayed(
     return sni.assertIsDisplayed()
 }
 
-inline fun retryUntilNotDisplayed(
-    description: String,
-    action: () -> Unit,
-    sni: SemanticsNodeInteraction,
-): SemanticsNodeInteraction {
-    var notDisplayed: Boolean = sni.isNotDisplayed()
-    var retries = 0
-    while (!notDisplayed && retries < MAX_RETRY_ATTEMPTS) {
-        runCatching(action)
-        retries++
-        notDisplayed = sni.isNotDisplayed()
-    }
-    Logger.withTag("retryUntilNotDisplayed").i { "After $retries retries is $notDisplayed for $description" }
-    return sni.assertIsNotDisplayed()
-}
-
 inline fun ComposeUiTest.waitUntilDisplayed(
     description: String,
     crossinline blockSNI: () -> SemanticsNodeInteraction,
@@ -76,6 +44,11 @@ inline fun ComposeUiTest.waitUntilDisplayed(
     return@waitUntil true
 }
 
+fun ComposeUiTest.waitUntilNotExist(tag: String) = waitUntilDoesNotExist(
+    matcher = hasTestTag(tag),
+    timeoutMillis = ASSERT_WAIT_TIMEOUT_MILLIS,
+)
+
 inline fun ComposeUiTest.waitAssert(
     description: String,
     crossinline assert: () -> Unit

ui/test/src/commonMain/kotlin/com/softartdev/notedelight/ui/cases/SettingPasswordTestCase.kt

@@ -5,7 +5,6 @@ package com.softartdev.notedelight.ui.cases
 import androidx.compose.ui.test.ComposeUiTest
 import androidx.compose.ui.test.ExperimentalTestApi
 import androidx.compose.ui.test.assertIsDisplayed
-import androidx.compose.ui.test.assertIsNotDisplayed
 import androidx.compose.ui.test.assertIsOff
 import androidx.compose.ui.test.assertIsOn
 import androidx.compose.ui.test.assertTextEquals
@@ -14,8 +13,10 @@ import androidx.compose.ui.test.performTextReplacement
 import co.touchlab.kermit.Logger
 import com.softartdev.notedelight.retryUntilDisplayed
 import com.softartdev.notedelight.ui.BaseTestCase
+import com.softartdev.notedelight.ui.dialog.security.CHANGE_PASSWORD_DIALOG_TAG
 import com.softartdev.notedelight.waitAssert
 import com.softartdev.notedelight.waitUntilDisplayed
+import com.softartdev.notedelight.waitUntilNotExist
 import kotlinx.coroutines.test.TestResult
 import kotlinx.coroutines.test.runTest
 import notedelight.ui.shared.generated.resources.Res
@@ -132,10 +133,8 @@ class SettingPasswordTestCase(
                 closeSoftKeyboard()
                 dialogSNI.assertIsDisplayed()
                 confirmDialogButtonSNI.performClick()
-                composeUiTest.waitAssert(
-                    description = "ChangePasswordDialog is not displayed",
-                    assert = dialogSNI::assertIsNotDisplayed
-                )
+                composeUiTest.awaitIdle()
+                composeUiTest.waitUntilNotExist(tag = CHANGE_PASSWORD_DIALOG_TAG)
             }
             logger.i { "SettingsTestScreen: Changing password completed, proceeding to disable encryption" }
             encryptionSwitchSNI