Skip to content

Commit 5187847

Browse files
committed
Fix arg parsing for bare-metal recipe
1 parent 948bc63 commit 5187847

File tree

2 files changed

+24
-12
lines changed

2 files changed

+24
-12
lines changed

Dockerfile

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,17 @@ FROM debian:latest as base
66
FROM base as build
77
WORKDIR /app
88

9-
# Add build argument for prebuilt binaries
109
ARG BUILD_QUICK=false
11-
ENV BUILD_QUICK=${BUILD_QUICK}
10+
ARG PEXECS
11+
ARG EXPERIMENTS
12+
ARG SUITES
13+
ARG MEASUREMENTS
14+
15+
ENV BUILD_QUICK=$BUILD_QUICK
16+
ENV PEXECS=$PEXECS
17+
ENV EXPERIMENTS=$EXPERIMENTS
18+
ENV SUITES=$SUITES
19+
ENV MEASUREMENTS=$MEASUREMENTS
1220

1321
RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
1422
--mount=type=cache,target=/var/lib/apt/lists,sharing=locked \
@@ -48,7 +56,7 @@ RUN mkdir -p /app/artefacts
4856
COPY . .
4957

5058
RUN if [ "$BUILD_QUICK" = "false" ]; then \
51-
invoke build-benchmarks; \
59+
invoke build-alloy $EXPERIMENTS $MEASUREMENTS; \
5260
else \
5361
echo "Using prebuilt binaries"; \
5462
cp -r ./artefacts/prebuilt /app/artefacts/; \
@@ -62,8 +70,5 @@ FROM debian:latest as runtime
6270
WORKDIR /app
6371
COPY --from=build /app/artefacts /app/artefacts
6472

65-
CMD invoke run-benchmarks $PEXECS \
66-
--experiments=$EXPERIMENTS \
67-
--suites=$SUITES \
68-
--metrics=$MEASUREMENTS
73+
CMD invoke run-benchmarks $PEXECS $EXPERIMENTS $SUITES $MEASUREMENTS
6974

Makefile

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
CURDIR ?= $(shell pwd)
2-
EXPERIMENTS ?= gcvs premopt elision
3-
MEASUREMENTS ?= perf mem metrics
42

53
IMAGE_full := full:latest
64
IMAGE_quick := quick:latest
@@ -32,7 +30,7 @@ run-quick: fetch-binaries
3230
docker buildx build \
3331
--target runtime \
3432
--tag $(IMAGE_quick) \
35-
--build-arg QUICK_BUILD=true \
33+
--build-arg BUILD_QUICK=true \
3634
--load .
3735
@test -f $(LOGFILE) || touch $(LOGFILE)
3836
chmod a+w $(LOGFILE)
@@ -42,7 +40,13 @@ run-quick: fetch-binaries
4240
$(IMAGE_quick)
4341

4442
run-full:
45-
docker buildx build --target runtime --tag $(IMAGE_full) --load .
43+
docker buildx build \
44+
--build-arg $(if $(EXPERIMENTS),EXPERIMENTS="--experiments $(EXPERIMENTS))" \
45+
--build-arg $(if $(SUITES),SUITES="--suites $(SUITES))" \
46+
--build-arg $(if $(MEASUREMENTS),MEASUREMENTS="--measurements $(MEASUREMENTS))" \
47+
--target runtime \
48+
--tag $(IMAGE_full) \
49+
--load .
4650
@test -f $(LOGFILE) || touch $(LOGFILE)
4751
chmod a+w $(LOGFILE)
4852
docker run --rm -it \
@@ -65,5 +69,8 @@ fetch-binaries: venv
6569
@echo "Done"
6670

6771
bare-metal: venv
68-
./run build-benchmarks
72+
@./run build-alloy \
73+
$(if $(EXPERIMENTS),--experiments $(EXPERIMENTS)) \
74+
$(if $(SUITES),--suites $(SUITES)) \
75+
$(if $(MEASUREMENTS),--measurements $(MEASUREMENTS))
6976

0 commit comments

Comments
 (0)