Skip to content

Commit 530cba7

Browse files
author
Golikov Pavel Evgenevich
committed
Add salt length setting in one-stage verify
1 parent 6c1e1d0 commit 530cba7

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

src/lib/crypto/OSSLRSA.cpp

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ bool OSSLRSA::sign(PrivateKey *privateKey, const ByteString &dataToSign,
233233
(EVP_PKEY_CTX_set_rsa_pss_saltlen(ctx, sParamLen) <= 0))
234234
{
235235
EVP_PKEY_CTX_free(ctx);
236-
ERROR_MSG("An error occurred while performing the RSA-PSS signature");
236+
ERROR_MSG("An error occurred while set the RSA-PSS signature parameters");
237237
return false;
238238
}
239239

@@ -817,10 +817,11 @@ bool OSSLRSA::verify(PublicKey *publicKey, const ByteString &originalData,
817817
if ((EVP_PKEY_verify_init(ctx) <= 0) ||
818818
(EVP_PKEY_CTX_set_rsa_padding(ctx, RSA_PKCS1_PSS_PADDING) <= 0) ||
819819
(EVP_PKEY_CTX_set_signature_md(ctx, hash) <= 0) ||
820-
(EVP_PKEY_CTX_set_rsa_mgf1_md(ctx, mgf) <= 0))
820+
(EVP_PKEY_CTX_set_rsa_mgf1_md(ctx, mgf) <= 0) ||
821+
(EVP_PKEY_CTX_set_rsa_pss_saltlen(ctx, sParamLen) <= 0))
821822
{
822823
EVP_PKEY_CTX_free(ctx);
823-
ERROR_MSG("RSA sign verify failed (0x%08X)", ERR_get_error());
824+
ERROR_MSG("RSA verify set PSS parameters failed (0x%08X)", ERR_get_error());
824825
return false;
825826
}
826827
int status = EVP_PKEY_verify(ctx, signature.const_byte_str(), signature.size(),
@@ -1222,18 +1223,18 @@ bool OSSLRSA::verifyFinal(const ByteString &signature)
12221223
(EVP_PKEY_CTX_set_signature_md(ctx, hash) <= 0))
12231224
{
12241225
EVP_PKEY_CTX_free(ctx);
1225-
ERROR_MSG("RSA sign verify failed (0x%08X)", ERR_get_error());
1226+
ERROR_MSG("RSA verify set parameters failed (0x%08X)", ERR_get_error());
12261227
return false;
12271228
}
12281229
if (rsaPadding == RSA_PKCS1_PSS_PADDING)
12291230
{
12301231
if ((EVP_PKEY_CTX_set_rsa_mgf1_md(ctx, hash) <= 0) ||
1231-
(EVP_PKEY_CTX_set_rsa_pss_saltlen(ctx, sLen) <= 0))
1232-
{
1233-
EVP_PKEY_CTX_free(ctx);
1234-
ERROR_MSG("RSA verify set mgf1 failed (0x%08X)", ERR_get_error());
1235-
return false;
1236-
}
1232+
(EVP_PKEY_CTX_set_rsa_pss_saltlen(ctx, sLen) <= 0))
1233+
{
1234+
EVP_PKEY_CTX_free(ctx);
1235+
ERROR_MSG("RSA verify set PSS parameters failed (0x%08X)", ERR_get_error());
1236+
return false;
1237+
}
12371238
}
12381239
int status = EVP_PKEY_verify(ctx, signature.const_byte_str(), signature.size(), digest.const_byte_str(), digest.size());
12391240
if (status < 0)

0 commit comments

Comments
 (0)