chore: improve various logging statements

Author: xeruf

gradle/build.gradle.kts

@@ -67,7 +67,7 @@ tasks {
     val release by creating {
         dependsOn(clean, check)
         group = "distribution"
-        description = "Prepares a new Release by bumping the version and creating a commit with a git tag for the new version"
+        description = "Prepares a new Release by bumping the version and creating and pushing a commit tagged with the new version"
         doLast {
             var newVersion = version
             fun String.editVersion(version: String, new: Int) =

plugin/src/main/kotlin/sc/plugin2022/Game.kt

@@ -116,12 +116,10 @@ class Game(override val currentState: GameState = GameState()): AbstractGame(Gam
                 }
                 player.hasLeft() -> {
                     cause = ScoreCause.LEFT
-                    reason = "Der Spieler hat das Spiel verlassen"
+                    reason = "Der Spieler hat das Spiel verlassen: ${player.left}"
                 }
             }
-        return PlayerScore(cause,
-                reason,
-                score,
+        return PlayerScore(cause, reason, score,
                 currentState.getPointsForTeam(team),
                 currentState.board.filterValues { it.team == team && it.type.isLight }
                         .maxOf { it.key.lightScore(team) }

sdk/src/main/server-api/sc/framework/plugins/AbstractGame.kt

@@ -29,7 +29,7 @@ abstract class AbstractGame(override val pluginUUID: String) : IGameInstance, Pa
 
     override val winner: ITeam?
         get() = players.singleOrNull { !it.hasViolated() && !it.hasLeft() }?.team ?:
-                checkWinCondition()?.also { logger.trace("No Winner via violation, WinCondition: {}", it) }?.winner
+                checkWinCondition()?.also { logger.debug("No Winner via violation, WinCondition: {}", it) }?.winner
 
     /** Pause the game after current turn has finished or continue playing. */
     override var isPaused = false

sdk/src/main/server-api/sc/networking/clients/XStreamClient.java

@@ -160,7 +160,7 @@ public void sendCustomData(String data) throws IOException {
   }
 
   public void sendCustomData(byte[] data) throws IOException {
-    logger.info("Sending custom data (size={})", data.length);
+    logger.info("Sending custom data ({} bytes)", data.length);
     networkInterface.getOutputStream().write(data);
     networkInterface.getOutputStream().flush();
   }

server/src/test/java/sc/server/network/LobbyTest.kt

@@ -1,5 +1,6 @@
 package sc.server.network
 
+import io.kotest.assertions.withClue
 import io.kotest.matchers.shouldBe
 import org.junit.jupiter.api.Test
 import sc.api.plugins.Team
@@ -50,7 +51,10 @@ class LobbyTest: RealServerTest() {
 
         await("Game is over") { room.isOver }
         await("Receive GameResult") { room.result != null }
-        room.result.scores.filterKeys { it.team == Team.ONE }.values.single().cause shouldBe ScoreCause.LEFT
+        withClue("Irregular GameResult") {
+            room.result.isRegular shouldBe false
+            room.result.scores.filterKeys { it.team == Team.ONE }.values.single().cause shouldBe ScoreCause.LEFT
+        }
 
         await("GameRoom closes") { gameMgr.games.isEmpty() }
     }