fix(plugin24): do not allow omitting movement checks

Can be more reliably enforced by raising movement points temporarily

Author: xeruf

plugin/src/main/kotlin/sc/plugin2024/Action.kt

@@ -5,5 +5,5 @@ import sc.shared.IMoveMistake
 
 @XStreamAlias(value = "action")
 interface Action {
-    fun perform(state: GameState, movementCheck: Boolean = true): IMoveMistake?
+    fun perform(state: GameState): IMoveMistake?
 }

plugin/src/main/kotlin/sc/plugin2024/actions/Accelerate.kt

@@ -38,7 +38,7 @@ data class Accelerate(
      * @param state [GameState], auf dem die Beschleunigung ausgeführt wird
      * @param ship [Ship], für welches die Beschleunigung ausgeführt wird
      */
-    override fun perform(state: GameState, movementCheck: Boolean): AccelerationProblem? {
+    override fun perform(state: GameState): AccelerationProblem? {
         var speed: Int = state.currentShip.speed
         speed += acc
         when {

plugin/src/main/kotlin/sc/plugin2024/actions/Advance.kt

@@ -31,12 +31,12 @@ data class Advance(
         @XStreamAsAttribute val distance: Int,
 ): Action {
 
-    override fun perform(state: GameState, movementCheck: Boolean): AdvanceProblem? {
+    override fun perform(state: GameState): AdvanceProblem? {
         if(distance < 1 && state.board[state.currentShip.position] != Field.SANDBANK || distance > 6)
             return AdvanceProblem.INVALID_DISTANCE
 
         val result = state.checkAdvanceLimit(state.currentShip.position, if(distance > 0) state.currentShip.direction else state.currentShip.direction.opposite(), state.currentShip.movement)
-        if(result.distance < distance.absoluteValue && movementCheck)
+        if(result.distance < distance.absoluteValue)
             return result.problem
 
         state.currentShip.position += state.currentShip.direction.vector * distance

plugin/src/main/kotlin/sc/plugin2024/actions/Push.kt

@@ -33,10 +33,10 @@ data class Push(
         @XStreamAsAttribute val direction: CubeDirection,
 ): Action {
 
-    override fun perform(state: GameState, movementCheck: Boolean): PushProblem? {
+    override fun perform(state: GameState): PushProblem? {
         val nudgedShip = state.otherShip
 
-        if(state.currentShip.movement == 0 && movementCheck)
+        if(state.currentShip.movement == 0)
             return PushProblem.MOVEMENT_POINTS_MISSING
         state.currentShip.movement--
 

plugin/src/main/kotlin/sc/plugin2024/actions/Turn.kt

@@ -27,7 +27,7 @@ data class Turn(
         @XStreamAsAttribute val direction: CubeDirection,
 ): Action {
 
-    override fun perform(state: GameState, movementCheck: Boolean): TurnProblem? {
+    override fun perform(state: GameState): TurnProblem? {
         val turnCount = state.currentShip.direction.turnCountTo(direction)
 
         val absTurnCount = turnCount.absoluteValue