fix(sdk): turn TooManyPlayersException into RuntimeException

Author: xeruf

plugin/src/server/sc/plugin2021/Game.kt

@@ -1,6 +1,7 @@
 package sc.plugin2021
 
 import org.slf4j.LoggerFactory
+import sc.api.plugins.exceptions.TooManyPlayersException
 import sc.framework.plugins.AbstractGame
 import sc.framework.plugins.ActionTimeout
 import sc.framework.plugins.Player
@@ -22,7 +23,7 @@ class Game(override val currentState: GameState = GameState()): AbstractGame<Pla
     private val availableTeams = mutableListOf(Team.ONE, Team.TWO)
     override fun onPlayerJoined(): Player {
         if (availableTeams.isEmpty())
-            throw IllegalStateException("Too many players joined the game!")
+            throw TooManyPlayersException()
         val player = currentState.getPlayer(availableTeams.removeAt(0))
 
         players.add(player)

sdk/src/server-api/sc/api/plugins/IGameInstance.kt

@@ -1,7 +1,6 @@
 package sc.api.plugins
 
 import sc.api.plugins.exceptions.GameLogicException
-import sc.api.plugins.exceptions.TooManyPlayersException
 import sc.api.plugins.host.IGameListener
 import sc.framework.plugins.Player
 import sc.protocol.room.RoomMessage
@@ -11,12 +10,7 @@ import sc.shared.ScoreCause
 import kotlin.jvm.Throws
 
 interface IGameInstance {
-    /**
-     * @return the player that joined
-     *
-     * @throws TooManyPlayersException when game is already full
-     */
-    @Throws(TooManyPlayersException::class)
+    /** @return the player that joined. */
     fun onPlayerJoined(): Player
     fun onPlayerLeft(player: Player, cause: ScoreCause? = null)
 

sdk/src/server-api/sc/api/plugins/exceptions/TooManyPlayersException.kt

@@ -1,3 +1,3 @@
 package sc.api.plugins.exceptions
 
-class TooManyPlayersException: GameRoomException("This game is full already.")
+class TooManyPlayersException: IllegalStateException("Attempted to join an already full game")