fix(network): handle SocketException more gracefully

Author: xeruf

sdk/src/server-api/sc/networking/clients/XStreamClient.java

@@ -138,8 +138,8 @@ public void receiveThread() {
         } else if (exceptionCause instanceof EOFException) {
           handleDisconnect(DisconnectCause.LOST_CONNECTION, e);
         } else if (exceptionCause instanceof IOException
-            && exceptionCause.getCause() != null && exceptionCause
-            .getCause() instanceof InterruptedException) {
+            && exceptionCause.getCause() != null
+            && exceptionCause.getCause() instanceof InterruptedException) {
           handleDisconnect(DisconnectCause.LOST_CONNECTION, e);
         } else {
           handleDisconnect(DisconnectCause.PROTOCOL_ERROR, e);
@@ -201,8 +201,6 @@ protected final void handleDisconnect(DisconnectCause cause) {
   protected final void handleDisconnect(DisconnectCause cause, Throwable exception) {
     if (exception != null) {
       logger.warn("{} disconnected (Cause: {}, Exception: {})", this, cause, exception);
-      if (logger.isDebugEnabled())
-        exception.printStackTrace();
     } else {
       logger.info("{} disconnected (Cause: {})", this, cause);
     }
@@ -263,7 +261,7 @@ protected synchronized void close() {
           this.out.close();
       } catch (Exception e) {
         if (e.getCause() instanceof SocketException)
-          logger.debug("Failed to close OUT", e);
+          logger.debug("Can't close OUT, Socket already closed: {}", e.toString());
         else
           logger.warn("Failed to close OUT", e);
       }

server/test/sc/server/network/LobbyTest.kt

@@ -6,6 +6,7 @@ import sc.server.client.TestLobbyClientListener
 import sc.server.gaming.GameRoom
 import sc.server.plugins.TestPlugin
 import sc.shared.ScoreCause
+import java.net.SocketException
 import kotlin.time.ExperimentalTime
 
 @ExperimentalTime
@@ -43,7 +44,10 @@ class LobbyTest: RealServerTest() {
         val room = gameMgr.games.single()
         room.isOver shouldBe false
 
-        player1.sendCustomData("<yarr>")
+        try {
+            player1.sendCustomData("<yarr>")
+        } catch(_: SocketException) {
+        }
 
         await("Game is over") { room.isOver }
         await("GameResult") { room.result != null }