test(server): prune little redundancies

Author: xeruf

sdk/src/test/sc/shared/WelcomeMessageTest.kt

@@ -1,16 +1,11 @@
 package sc.shared
 
 import io.kotest.core.spec.style.StringSpec
-import sc.api.plugins.ITeam
+import sc.api.plugins.TestTeam
 import sc.helpers.shouldSerializeTo
 
 class WelcomeMessageTest: StringSpec({
     "XML Serialization" {
-        val team = object: ITeam {
-            override val index: Int = 2
-            override val name = "testi"
-            override fun opponent(): ITeam = this
-        }
-        WelcomeMessage(team) shouldSerializeTo """<welcomeMessage color="testi"/>"""
+        WelcomeMessage(TestTeam.BLUE) shouldSerializeTo """<welcomeMessage color="${TestTeam.BLUE.name}"/>"""
     }
 })

server/test/sc/server/network/LobbyRequestTest.kt

@@ -94,6 +94,7 @@ class LobbyRequestTest: WordSpec({
                 game.isPaused shouldBe false
                 withClue("Processes moves") {
                     game.activePlayer?.color shouldBe TestTeam.RED
+                    // TODO occasional failure
                     playerListeners[0].waitForMessage(MoveRequest::class)
                     players[0].sendMessageToRoom(roomId, TestMove(1))
                     await { game.currentState.state shouldBe 1 }

server/test/sc/server/plugins/TestGame.kt

@@ -1,6 +1,5 @@
 package sc.server.plugins
 
-import org.slf4j.LoggerFactory
 import sc.api.plugins.exceptions.TooManyPlayersException
 import sc.framework.plugins.AbstractGame
 import sc.framework.plugins.ActionTimeout
@@ -41,7 +40,6 @@ data class TestGame(
     }
 
     override fun onPlayerLeft(player: Player, cause: ScoreCause?) {
-        logger.debug("Player left $player")
         val result = generateScoreMap().toMutableMap()
         result[player] = PlayerScore(cause ?: ScoreCause.LEFT, "Spieler hat das Spiel verlassen.", 0)
         notifyOnGameOver(result)
@@ -56,8 +54,4 @@ data class TestGame(
 
     override fun toString(): String =
             "TestGame(currentState=$currentState, paused=$isPaused, players=$players)"
-    
-    companion object {
-        private val logger = LoggerFactory.getLogger(TestGame::class.java)
-    }
 }