test(server): update authentication test

Author: xeruf

server/src/test/java/sc/server/helpers/StringNetworkInterface.kt

@@ -2,34 +2,22 @@ package sc.server.helpers
 
 import sc.networking.INetworkInterface
 import java.io.ByteArrayOutputStream
-import java.io.IOException
 import java.io.InputStream
 import java.io.OutputStream
 
 class StringNetworkInterface(data: String): INetworkInterface {
+    private val inputStream = NonEndingByteArrayInputStream(data.toByteArray())
     private val outputStream = ByteArrayOutputStream()
-    private val inputStream: InputStream = NonEndingByteArrayInputStream(data.toByteArray())
 
-    @Throws(IOException::class)
+    override fun getInputStream(): InputStream = inputStream
+    override fun getOutputStream(): OutputStream = outputStream
     override fun close() {
+        inputStream.close()
+        outputStream.close()
     }
 
-    @Throws(IOException::class)
-    override fun getInputStream(): InputStream {
-        return inputStream
+    fun readData(): String {
+        outputStream.flush()
+        return outputStream.toString()
     }
-    
-    @Throws(IOException::class)
-    override fun getOutputStream(): OutputStream {
-        return outputStream
-    }
-    
-    @get:Throws(IOException::class)
-    val data: String
-        get() {
-            outputStream.flush()
-            return outputStream.toString()
-        }
-    
-    override fun toString(): String = "String@" + this.hashCode()
 }

server/src/test/java/sc/server/network/ClientXmlReadTest.java

@@ -48,7 +48,7 @@ public void clientSendPacketTest() throws IOException {
 
     client.start();
     client.send(new ExamplePacket());
-    String data = stringInterface.getData();
+    String data = stringInterface.readData();
     assertEquals("<protocol>\n  <example/>", data);
   }
 

server/src/test/java/sc/server/network/LobbyRequestTest.kt

@@ -1,17 +1,43 @@
 package sc.server.network
 
+import io.kotest.assertions.throwables.shouldThrow
 import io.kotest.core.spec.style.FunSpec
-import io.kotest.matchers.collections.shouldHaveSize
+import io.kotest.matchers.booleans.*
+import io.kotest.matchers.collections.*
+import sc.protocol.requests.AuthenticateRequest
 import sc.protocol.requests.JoinGameRequest
+import sc.server.Configuration
 import sc.server.Lobby
 import sc.server.helpers.StringNetworkInterface
 
+class DummyClient(private val data: String = "", private val networkInterface: StringNetworkInterface = StringNetworkInterface(data)): Client(networkInterface) {
+    init {
+        start()
+    }
+    fun readData() = networkInterface.readData()
+}
+
 class LobbyRequestTest: FunSpec({
-    test("join without gametype") {
-        val dummy = Client(StringNetworkInterface("")).apply { start() }
-        val lobby = Lobby()
-        val callback = PacketCallback(JoinGameRequest(null))
-        lobby.onRequest(dummy, callback)
-        await("Starts a game") { lobby.games shouldHaveSize 1 }
+    val lobby = Lobby()
+    val dummy = DummyClient()
+    context("join game") {
+        test("without gametype creates a room") {
+            lobby.onRequest(dummy, PacketCallback(JoinGameRequest(null)))
+            lobby.games shouldHaveSize 1
+        }
+    }
+    context("admin authentication") {
+        val pwd = "Bobby"
+        test("wrong password") {
+            shouldThrow<AuthenticationFailedException> {
+                lobby.onRequest(dummy, PacketCallback(AuthenticateRequest(pwd)))
+            }
+            dummy.isAdministrator.shouldBeFalse()
+        }
+        test("wrong password") {
+            Configuration.set(Configuration.PASSWORD_KEY, pwd)
+            lobby.onRequest(dummy, PacketCallback(AuthenticateRequest(pwd)))
+            dummy.isAdministrator.shouldBeTrue()
+        }
     }
 })

server/src/test/java/sc/server/network/RequestTest.kt

@@ -2,7 +2,8 @@ package sc.server.network
 
 import io.kotest.matchers.*
 import io.kotest.matchers.ints.*
-import org.junit.jupiter.api.Assertions.*
+import org.junit.jupiter.api.Assertions.assertEquals
+import org.junit.jupiter.api.Assertions.assertFalse
 import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Test
 import sc.framework.plugins.Pausable
@@ -12,14 +13,15 @@ import sc.protocol.requests.PauseGameRequest
 import sc.protocol.requests.StepRequest
 import sc.protocol.room.ErrorMessage
 import sc.protocol.room.MoveRequest
+import sc.protocol.room.WelcomeMessage
 import sc.server.client.PlayerListener
 import sc.server.client.TestLobbyClientListener
 import sc.server.gaming.GameRoom
 import sc.server.helpers.TestHelper
 import sc.server.plugins.TestMove
 import sc.server.plugins.TestPlugin
-import sc.protocol.room.WelcomeMessage
 
+// TODO Migrate to LobbyRequestTest
 class RequestTest: RealServerTest() {
     private lateinit var player1: LobbyClient
     private lateinit var player2: LobbyClient
@@ -35,22 +37,6 @@ class RequestTest: RealServerTest() {
         Thread.sleep(200)
     }
 
-    @Test
-    fun authenticationRequest() {
-        player1.authenticate(PASSWORD)
-        Thread.sleep(200)
-        val clients = lobby.clientManager.clients
-        assertTrue(clients[0].isAdministrator)
-        assertEquals(3, lobby.clientManager.clients.size.toLong())
-        
-        player2.authenticate("PASSWORD_FAIL_TEST")
-        Thread.sleep(200)
-        
-        // Player2 got kicked
-        assertEquals(2, lobby.clientManager.clients.size.toLong())
-        assertFalse(clients[1].isAdministrator)
-    }
-    
     @Test
     fun observationRequest() {
         player1.joinGame(TestPlugin.TEST_PLUGIN_UUID)

server/src/test/java/sc/server/plugins/TestGame.kt

@@ -27,13 +27,13 @@ data class TestGame(
         move.perform(currentState)
         next()
     }
-
+    
     override fun checkWinCondition(): WinCondition? {
         return if (currentState.round > 1) {
             WinCondition(if (currentState.state % 2 == 0) Team.ONE else Team.TWO, TestWinReason.WIN)
         } else null
     }
-
+    
     override fun onPlayerJoined(): Player {
         if (players.size < 2) {
             return if (players.isEmpty()) {
@@ -44,13 +44,17 @@ data class TestGame(
         }
         throw TooManyPlayersException()
     }
-
+    
     override fun getScoreFor(player: Player) =
-            if(player.hasLeft())
-                PlayerScore(ScoreCause.LEFT, "Spieler ist rausgeflogen.", 0)
-            else
-                PlayerScore(true, "Spieler hat gewonnen.")
-
+            when {
+                player.hasLeft() ->
+                    PlayerScore(ScoreCause.LEFT, "Spieler ist rausgeflogen.", 0)
+                player.hasViolated() ->
+                    PlayerScore(ScoreCause.RULE_VIOLATION, player.violationReason!!, 0)
+                else ->
+                    PlayerScore(true, "Spieler hat gewonnen.")
+            }
+    
     override fun getTimeoutFor(player: Player): ActionTimeout =
             ActionTimeout(false)