fix(Game): simplify winners calculation

Author: xeruf

plugin/src/server/sc/plugin2021/Game.kt

@@ -31,15 +31,11 @@ class Game(override val currentState: GameState = GameState()): AbstractGame<Pla
         return player
     }
 
-    override val winners: MutableList<Player>
+    override val winners: List<Player>
         get() {
-            if (players.first().hasViolated()) {
-                if (players.last().hasViolated())
-                    return mutableListOf()
-                return players.subList(1, 2)
-            }
-            if (players.last().hasViolated())
-                return players.subList(0, 1)
+            val compliant = players.filter { !it.hasViolated() && !it.hasLeft() }
+            if (compliant.size < players.size)
+                return compliant
 
             val first = currentState.getPointsForPlayer(players.first().color)
             val second = currentState.getPointsForPlayer(players.last().color)

server/test/sc/server/gaming/GameRoomTest.kt

@@ -70,6 +70,12 @@ class GameRoomTest: WordSpec({
                     <score cause="REGULAR" reason="Game terminated">
                       <part>0</part>
                     </score>
+                    <winner displayName="">
+                      <color class="sc.server.helpers.TestTeam">RED</color>
+                    </winner>
+                    <winner displayName="">
+                      <color class="sc.server.helpers.TestTeam">BLUE</color>
+                    </winner>
                   </data>
                 </room>
                 </protocol>

server/test/sc/server/plugins/TestGame.kt

@@ -12,8 +12,11 @@ data class TestGame(
         override val currentState: TestGameState = TestGameState(),
 ): AbstractGame<Player>(TestPlugin.TEST_PLUGIN_UUID) {
 
-    override val playerScores: List<PlayerScore> = emptyList()
-    override val winners: List<Player> = emptyList()
+    override val playerScores: List<PlayerScore>
+        get() = players.map { getScoreFor(it) }
+    
+    override val winners: List<Player>
+        get() = players.filter { !it.hasViolated() && !it.hasLeft() }
 
     override fun onRoundBasedAction(fromPlayer: Player, move: IMove) {
         if (move !is TestMove)