rework(network): separate room-specific protocol classes

Author: xeruf

GUIDELINES.md

@@ -52,10 +52,7 @@ The information which implementations to use resides in [resources/META-INF/serv
 ## Networking Protocol Classes
 
 [ProtocolPacket](sdk/src/server-api/sc/protocol/ProtocolPacket.kt) is the common interface
-for everything that is to be sent via the XML Protocol.
-
-Data sent to a specific room has to implement [RoomMessage](sdk/src/server-api/sc/protocol/RoomMessage.kt)
-and is then wrapped in a [RoomPacket](sdk/src/server-api/sc/protocol/RoomPacket.kt).
+for objects sent via the XML Protocol.
 
 ### [Requests](sdk/src/server-api/sc/protocol/requests)
 - are all suffixed with `Request`
@@ -67,3 +64,12 @@ and is then wrapped in a [RoomPacket](sdk/src/server-api/sc/protocol/RoomPacket.
 
 (*Response) Response to a request  
 (*Event) Update to all observers
+
+#### [Room Messages](sdk/src/server-api/sc/protocol/room)
+
+Data sent to a specific room has to implement [RoomMessage](sdk/src/server-api/sc/protocol/room/RoomMessage.kt)
+and is then wrapped in a [RoomPacket](sdk/src/server-api/sc/protocol/room/RoomPacket.kt).
+
+The package contains a few standard messages,
+but most will be implemented in the corresponding plugin.
+

helpers/test-client/src/sc/TestClient.java

@@ -11,7 +11,7 @@
 import sc.networking.clients.XStreamClient;
 import sc.protocol.CloseConnection;
 import sc.protocol.ProtocolPacket;
-import sc.protocol.RoomPacket;
+import sc.protocol.room.RoomPacket;
 import sc.protocol.requests.*;
 import sc.protocol.responses.*;
 import sc.server.Configuration;

plugin/src/client/sc/plugin2021/AbstractClient.kt

@@ -7,9 +7,9 @@ import sc.networking.clients.AbstractLobbyClientListener
 import sc.networking.clients.IControllableGame
 import sc.networking.clients.ILobbyClientListener
 import sc.networking.clients.LobbyClient
-import sc.protocol.RoomMessage
+import sc.protocol.room.RoomMessage
 import sc.protocol.responses.GamePreparedResponse
-import sc.protocol.responses.ErrorMessage
+import sc.protocol.room.ErrorMessage
 import sc.shared.GameResult
 import sc.shared.WelcomeMessage
 import java.net.ConnectException

plugin/src/server/sc/plugin2021/Game.kt

@@ -8,7 +8,7 @@ import sc.plugin2021.util.Constants
 import sc.plugin2021.util.GameRuleLogic
 import sc.plugin2021.util.MoveMistake
 import sc.plugin2021.util.WinReason
-import sc.protocol.RoomMessage
+import sc.protocol.room.RoomMessage
 import sc.shared.InvalidMoveException
 import sc.shared.PlayerScore
 import sc.shared.ScoreCause

sdk/src/framework/sc/shared/GameResult.kt

@@ -3,7 +3,7 @@ package sc.shared
 import com.thoughtworks.xstream.annotations.XStreamAlias
 import com.thoughtworks.xstream.annotations.XStreamImplicit
 import sc.framework.plugins.Player
-import sc.protocol.RoomMessage
+import sc.protocol.room.RoomMessage
 
 /**
  * Das Endergebnis eines Spiels.

sdk/src/framework/sc/shared/WelcomeMessage.kt

@@ -3,7 +3,7 @@ package sc.shared
 import com.thoughtworks.xstream.annotations.XStreamAlias
 import com.thoughtworks.xstream.annotations.XStreamAsAttribute
 import sc.api.plugins.ITeam
-import sc.protocol.RoomMessage
+import sc.protocol.room.RoomMessage
 
 /** Nachricht, die zu Beginn eines Spiels an einen Client geschickt wird, um ihm seine Spielerfarbe mitzuteilen.  */
 @Suppress("DataClassPrivateConstructor")

sdk/src/server-api/sc/api/plugins/IGameInstance.kt

@@ -4,7 +4,7 @@ import sc.api.plugins.exceptions.GameLogicException
 import sc.api.plugins.exceptions.TooManyPlayersException
 import sc.api.plugins.host.IGameListener
 import sc.framework.plugins.Player
-import sc.protocol.RoomMessage
+import sc.protocol.room.RoomMessage
 import sc.shared.InvalidMoveException
 import sc.shared.PlayerScore
 import sc.shared.ScoreCause

sdk/src/server-api/sc/api/plugins/IGameState.kt

@@ -1,6 +1,6 @@
 package sc.api.plugins
 
-import sc.protocol.RoomMessage
+import sc.protocol.room.RoomMessage
 
 /**
  * Ein `GameState` beinhaltet alle Informationen, die den Spielstand zu

sdk/src/server-api/sc/api/plugins/IMove.kt

@@ -1,5 +1,5 @@
 package sc.api.plugins
 
-import sc.protocol.RoomMessage
+import sc.protocol.room.RoomMessage
 
 interface IMove: RoomMessage

sdk/src/server-api/sc/api/plugins/exceptions/NotYourTurnException.kt

@@ -1,7 +1,7 @@
 package sc.api.plugins.exceptions
 
 import sc.framework.plugins.Player
-import sc.protocol.RoomMessage
+import sc.protocol.room.RoomMessage
 
 data class NotYourTurnException(
         val expected: Player?,