Skip to content

Commit d215da5

Browse files
authored
chore: use alternative terms (googleapis#1157)
1 parent b091bfc commit d215da5

File tree

30 files changed

+106
-106
lines changed

30 files changed

+106
-106
lines changed

gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta):
388388
{% if not method.client_streaming %}
389389
# Create or coerce a protobuf request object.
390390
{% if method.flattened_fields %}
391-
# Sanity check: If we got a request object, we should *not* have
391+
# Quick check: If we got a request object, we should *not* have
392392
# gotten any keyword arguments that map to the request.
393393
has_flattened_params = any([{{ method.flattened_fields.values()|join(", ", attribute="name") }}])
394394
if request is not None and has_flattened_params:

gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/grpc.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ class {{ service.name }}GrpcTransport({{ service.name }}Transport):
234234
This property caches on the instance; repeated calls return the same
235235
client.
236236
"""
237-
# Sanity check: Only create a new client if we do not already have one.
237+
# Quick check: Only create a new client if we do not already have one.
238238
if self._operations_client is None:
239239
self._operations_client = operations_v1.OperationsClient(
240240
self.grpc_channel

gapic/generator/generator.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ def get_response(
112112
# and instead of iterating over it/them, we iterate over samples
113113
# and plug those into the template.
114114
for template_name in client_templates:
115-
# Sanity check: Skip "private" templates.
115+
# Quick check: Skip "private" templates.
116116
filename = template_name.split("/")[-1]
117117
if filename.startswith("_") and filename != "__init__.py.j2":
118118
continue
@@ -242,7 +242,7 @@ def _render_template(
242242
if not opts.metadata and template_name.endswith("gapic_metadata.json.j2"):
243243
return answer
244244

245-
# Sanity check: Rendering per service and per proto would be a
245+
# Quick check: Rendering per service and per proto would be a
246246
# combinatorial explosion and is almost certainly not what anyone
247247
# ever wants. Error colorfully on it.
248248
if "%service" in template_name and "%proto" in template_name:
@@ -343,7 +343,7 @@ def _get_file(
343343
name=fn,
344344
)
345345

346-
# Sanity check: Do not render empty files.
346+
# Quick check: Do not render empty files.
347347
if utils.empty(cgr_file.content) and not fn.endswith(
348348
("py.typed", "__init__.py")
349349
):

gapic/schema/api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ def python_modules(self) -> Sequence[Tuple[str, str]]:
195195
answer = {
196196
t.ident.python_import
197197
for m in self.all_messages.values()
198-
# Sanity check: We do make sure that we are not trying to have
198+
# Quick check: We do make sure that we are not trying to have
199199
# a module import itself.
200200
for t in m.field_types if t.ident.python_import != self_reference
201201
}

gapic/schema/naming.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def build(
7777
proto_packages = {fd.package for fd in file_descriptors}
7878
root_package = os.path.commonprefix(tuple(proto_packages)).rstrip('.')
7979

80-
# Sanity check: If there is no common ground in the package,
80+
# Quick check: If there is no common ground in the package,
8181
# we are obviously in trouble.
8282
if not root_package:
8383
raise ValueError(
@@ -119,7 +119,7 @@ def build(
119119
version=match.get('version', ''),
120120
)
121121

122-
# Sanity check: Ensure that the package directives all inferred
122+
# Quick check: Ensure that the package directives all inferred
123123
# the same information.
124124
if not package_info.version and len(proto_packages) > 1:
125125
raise ValueError('All protos must have the same proto package '

gapic/schema/wrappers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ def get_field(self, *field_path: str,
541541
visited_messages=frozenset({self}),
542542
)
543543

544-
# Sanity check: If cursor is a repeated field, then raise an exception.
544+
# Quick check: If cursor is a repeated field, then raise an exception.
545545
# Repeated fields are only permitted in the terminal position.
546546
if cursor.repeated:
547547
raise KeyError(
@@ -552,7 +552,7 @@ def get_field(self, *field_path: str,
552552
'in the fields list in a position other than the end.',
553553
)
554554

555-
# Sanity check: If this cursor has no message, there is a problem.
555+
# Quick check: If this cursor has no message, there is a problem.
556556
if not cursor.message:
557557
raise KeyError(
558558
f'Field {".".join(field_path)} could not be resolved from '

gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ class {{ service.async_client_name }}:
256256
{% if not method.client_streaming %}
257257
# Create or coerce a protobuf request object.
258258
{% if method.flattened_fields %}
259-
# Sanity check: If we got a request object, we should *not* have
259+
# Quick check: If we got a request object, we should *not* have
260260
# gotten any keyword arguments that map to the request.
261261
has_flattened_params = any([{{ method.flattened_fields.values()|join(", ", attribute="name") }}])
262262
if request is not None and has_flattened_params:

gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta):
422422
{% if not method.client_streaming %}
423423
# Create or coerce a protobuf request object.
424424
{% if method.flattened_fields %}
425-
# Sanity check: If we got a request object, we should *not* have
425+
# Quick check: If we got a request object, we should *not* have
426426
# gotten any keyword arguments that map to the request.
427427
has_flattened_params = any([{{ method.flattened_fields.values()|join(", ", attribute="name") }}])
428428
if request is not None and has_flattened_params:

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ class {{ service.name }}GrpcTransport({{ service.name }}Transport):
234234
This property caches on the instance; repeated calls return the same
235235
client.
236236
"""
237-
# Sanity check: Only create a new client if we do not already have one.
237+
# Quick check: Only create a new client if we do not already have one.
238238
if self._operations_client is None:
239239
self._operations_client = operations_v1.OperationsClient(
240240
self.grpc_channel

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ class {{ service.grpc_asyncio_transport_name }}({{ service.name }}Transport):
235235
This property caches on the instance; repeated calls return the same
236236
client.
237237
"""
238-
# Sanity check: Only create a new client if we do not already have one.
238+
# Quick check: Only create a new client if we do not already have one.
239239
if self._operations_client is None:
240240
self._operations_client = operations_v1.OperationsAsyncClient(
241241
self.grpc_channel

0 commit comments

Comments
 (0)