Simplify implicit pointer dereferencing

Author: iwoplaza

packages/typegpu/src/core/function/dualImpl.ts

@@ -70,7 +70,13 @@ export function dualImpl<T extends (...args: never[]) => unknown>(
   const gpuImpl = (...args: MapValueToSnippet<Parameters<T>>) => {
     const { argTypes, returnType } = typeof options.signature === 'function'
       ? options.signature(
-        ...args.map((s) => s.dataType) as MapValueToDataType<Parameters<T>>,
+        ...args.map((s) => {
+          // Dereference implicit pointers
+          if (s.dataType.type === 'ptr' && s.dataType.implicit) {
+            return s.dataType.inner;
+          }
+          return s.dataType;
+        }) as MapValueToDataType<Parameters<T>>,
       )
       : options.signature;
 

packages/typegpu/src/data/dataTypes.ts

@@ -146,10 +146,6 @@ export function toStorable(schema: AnyData): AnyData {
   return undecorate(unptr(undecorate(schema)));
 }
 
-export function toStorables<T extends AnyData[]>(schemas: T): T {
-  return schemas.map(toStorable) as T;
-}
-
 const looseTypeLiterals = [
   'unstruct',
   'disarray',

packages/typegpu/src/data/vector.ts

@@ -1,7 +1,7 @@
 import { dualImpl } from '../core/function/dualImpl.ts';
 import { stitch } from '../core/resolve/stitch.ts';
 import { $repr } from '../shared/symbols.ts';
-import { type AnyData, toStorable } from './dataTypes.ts';
+import type { AnyData } from './dataTypes.ts';
 import { bool, f16, f32, i32, u32 } from './numeric.ts';
 import {
   Vec2bImpl,
@@ -310,10 +310,7 @@ function makeVecSchema<TValue, S extends number | boolean>(
   const construct = dualImpl({
     name: type,
     signature: (...args) => ({
-      argTypes: args.map((arg) => {
-        const argType = toStorable(arg);
-        return isVec(argType) ? argType : primitive;
-      }),
+      argTypes: args.map((arg) => isVec(arg) ? arg : primitive),
       returnType: schema as AnyData,
     }),
     normalImpl: cpuConstruct,

packages/typegpu/src/std/boolean.ts

@@ -1,6 +1,6 @@
 import { dualImpl } from '../core/function/dualImpl.ts';
 import { stitch } from '../core/resolve/stitch.ts';
-import { type AnyData, toStorables } from '../data/dataTypes.ts';
+import type { AnyData } from '../data/dataTypes.ts';
 import { bool, f32 } from '../data/numeric.ts';
 import { isSnippetNumeric, snip } from '../data/snippet.ts';
 import { vec2b, vec3b, vec4b } from '../data/vector.ts';
@@ -338,8 +338,7 @@ function cpuSelect<T extends number | boolean | AnyVecInstance>(
  */
 export const select = dualImpl({
   name: 'select',
-  signature: (...args) => {
-    const [f, t, cond] = toStorables(args);
+  signature: (f, t, cond) => {
     const [uf, ut] = unify([f, t]) ?? [f, t] as const;
     return ({ argTypes: [uf, ut, cond], returnType: uf });
   },