Skip to content

Commit 3b3ee2d

Browse files
authored
kraleppa
* Separate scrolls for pinned assigns and all assigns * Long pinned assigns have fixed space size on the left * Made assigns sizes stick to right upper corner even when scrolling * Adjusted section title size for assigns
1 parent d247255 commit 3b3ee2d

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

lib/live_debugger/app/debugger/node_state/web/components.ex

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ defmodule LiveDebugger.App.Debugger.NodeState.Web.Components do
4242

4343
~H"""
4444
<div id="assigns-section-container" phx-hook="AssignsBodySearchHighlight">
45-
<.section id="assigns" class="h-max overflow-y-hidden" title="Assigns">
45+
<.section id="assigns" class="h-max overflow-y-hidden" title="Assigns" title_class="!min-w-14">
4646
<:right_panel>
4747
<div class="flex gap-2">
4848
<AssignsSearch.render
@@ -59,16 +59,18 @@ defmodule LiveDebugger.App.Debugger.NodeState.Web.Components do
5959
class="w-full h-max max-h-full overflow-y-auto"
6060
data-search_phrase={@assigns_search_phrase}
6161
>
62-
<div id="pinned-assigns" class="p-4 border-b border-default-border">
62+
<div id="pinned-assigns" class="p-4 border-b border-default-border overflow-x-auto">
6363
<.pinned_assigns_section
6464
id="pinned-"
6565
term_node={@term_node}
6666
pinned_assigns={@pinned_assigns}
6767
/>
6868
</div>
69-
<div id="all-assigns" class="p-4 relative">
69+
<div id="all-assigns" class="relative">
7070
<.assigns_sizes_section assigns_sizes={@assigns_sizes} id="display-container-size-label" />
71-
<ElixirDisplay.static_term id="assigns-" node={@term_node} selectable_level={1} />
71+
<div class="p-4 overflow-x-auto">
72+
<ElixirDisplay.static_term id="assigns-" node={@term_node} selectable_level={1} />
73+
</div>
7274
</div>
7375
</div>
7476
</.section>
@@ -80,16 +82,18 @@ defmodule LiveDebugger.App.Debugger.NodeState.Web.Components do
8082
/>
8183
</:search_bar_slot>
8284
<div id="assigns-display-fullscreen-container" data-search_phrase={@assigns_search_phrase}>
83-
<div class="p-4 border-b border-default-border">
85+
<div class="p-4 border-b border-default-border overflow-x-auto">
8486
<.pinned_assigns_section
8587
id="pinned-fullscreen-"
8688
term_node={@term_node}
8789
pinned_assigns={@pinned_assigns}
8890
/>
8991
</div>
90-
<div class="p-4 relative">
92+
<div class="relative">
9193
<.assigns_sizes_section assigns_sizes={@assigns_sizes} id="display-fullscreen-size-label" />
92-
<ElixirDisplay.static_term id="fullscreen-" node={@term_node} selectable_level={1} />
94+
<div class="p-4 overflow-x-auto">
95+
<ElixirDisplay.static_term id="fullscreen-" node={@term_node} selectable_level={1} />
96+
</div>
9397
</div>
9498
</div>
9599
</.fullscreen>
@@ -111,7 +115,7 @@ defmodule LiveDebugger.App.Debugger.NodeState.Web.Components do
111115
:if={pinned}
112116
class="flex min-h-4.5 [&>div>button]:hidden hover:[&>div>button]:block"
113117
>
114-
<div class="w-4">
118+
<div class="w-4 shrink-0">
115119
<button
116120
class="text-button-red-content hover:text-button-red-content-hover"
117121
phx-click="unpin-assign"

lib/live_debugger/app/web/components.ex

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,7 @@ defmodule LiveDebugger.App.Web.Components do
288288
attr(:id, :string, required: true)
289289
attr(:title, :string, required: true)
290290
attr(:class, :any, default: nil)
291+
attr(:title_class, :any, default: nil)
291292
attr(:inner_class, :any, default: nil)
292293

293294
slot(:right_panel)
@@ -304,7 +305,7 @@ defmodule LiveDebugger.App.Web.Components do
304305
>
305306
<div class="px-4 flex items-center h-12 p-2 border-b border-default-border">
306307
<div class="flex justify-between items-center w-full gap-2">
307-
<div class="font-medium text-sm min-w-26"><%= @title %></div>
308+
<div class={["font-medium text-sm min-w-26" | List.wrap(@title_class)]}><%= @title %></div>
308309
<div class="w-max">
309310
<%= render_slot(@right_panel) %>
310311
</div>

0 commit comments

Comments
 (0)