Bug: Lack of exception trace (#732)

* Fix

* Fix ProcessMonitor crashing when live view not alive

* Add test for exception trace

Author: hhubert6

lib/live_debugger/services/callback_tracer/gen_servers/trace_handler.ex

@@ -152,7 +152,7 @@ defmodule LiveDebugger.Services.CallbackTracer.GenServers.TraceHandler do
          params <- %{execution_time: execution_time, type: type},
          {:ok, updated_trace} <- TraceActions.update_trace(trace, params),
          {:ok, ref} <- TraceActions.persist_trace(updated_trace, ref),
-         :ok <- StateActions.maybe_save_state!(updated_trace),
+         _ <- StateActions.maybe_save_state!(updated_trace),
          :ok <- TraceActions.publish_trace(updated_trace, ref) do
       {:noreply, delete_trace_record(state, trace_key)}
     else

lib/live_debugger/services/process_monitor/actions.ex

@@ -35,13 +35,18 @@ defmodule LiveDebugger.Services.ProcessMonitor.Actions do
   def register_live_view_born!(state, pid, transport_pid) do
     Process.monitor(pid)
 
-    {:ok, components} = LiveViewDebug.live_components(pid)
-    node_ids = Enum.map(components, &%Phoenix.LiveComponent.CID{cid: &1.cid})
-    new_state = Map.put(state, pid, MapSet.new(node_ids))
+    case LiveViewDebug.live_components(pid) do
+      {:ok, components} ->
+        node_ids = Enum.map(components, &%Phoenix.LiveComponent.CID{cid: &1.cid})
+        new_state = Map.put(state, pid, MapSet.new(node_ids))
 
-    Bus.broadcast_event!(%LiveViewBorn{pid: pid, transport_pid: transport_pid})
+        Bus.broadcast_event!(%LiveViewBorn{pid: pid, transport_pid: transport_pid})
 
-    new_state
+        new_state
+
+      _ ->
+        state
+    end
   end
 
   @spec register_live_view_died!(ProcessMonitor.state(), pid()) :: ProcessMonitor.state()

test/e2e/dead_view_mode_test.exs

@@ -45,6 +45,31 @@ defmodule LiveDebugger.E2E.DeadViewModeTest do
     |> assert_has(css("label.pointer-events-none", text: "Highlight"))
   end
 
+  @sessions 2
+  feature "traces ended with exception are visible in dead view mode", %{
+    sessions: [dev_app, debugger]
+  } do
+    LiveDebugger.Services.CallbackTracer.GenServers.TracingManager.ping!()
+    LiveDebugger.API.SettingsStorage.save(:dead_view_mode, true)
+
+    dev_app
+    |> visit(@dev_app_url)
+
+    debugger
+    |> visit("/")
+    |> click(first_link())
+    |> click(global_callback_traces_button())
+    |> click(clear_traces_button())
+    |> click(toggle_tracing_button())
+
+    dev_app
+    |> click(css("button[phx-click=\"crash\"]"))
+
+    debugger
+    |> find(global_traces(count: 1))
+    |> assert_has(css("summary.border-error-icon"))
+  end
+
   defp global_traces(opts), do: css("#global-traces-stream details", opts)
 
   defp global_callback_traces_button(), do: css("button[aria-label=\"Icon globe\"]")