Enhancement: Remove Trace body from DOM on collapsible close (#818)

Author: hhubert6

lib/live_debugger/app/debugger/callback_tracing/structs/trace_display.ex

@@ -60,9 +60,9 @@ defmodule LiveDebugger.App.Debugger.CallbackTracing.Structs.TraceDisplay do
     }
   end
 
-  @spec render_body(t()) :: t()
-  def render_body(%__MODULE__{} = trace) do
-    Map.put(trace, :render_body?, true)
+  @spec render_body(t(), boolean()) :: t()
+  def render_body(%__MODULE__{} = trace, value? \\ true) do
+    Map.put(trace, :render_body?, value?)
   end
 
   @spec short_content(t(), boolean()) :: String.t()

lib/live_debugger/app/debugger/callback_tracing/web/hook_components/trace_wrapper.ex

@@ -51,8 +51,9 @@ defmodule LiveDebugger.App.Debugger.CallbackTracing.Web.HookComponents.TraceWrap
       chevron_class="w-5 h-5 text-accent-icon"
       class={["max-w-full border rounded last:mb-4", border_color_class(@trace_display)]}
       label_class="font-semibold bg-surface-1-bg p-2 py-3 rounded"
-      phx-click={if(@trace_display.render_body?, do: nil, else: "toggle-collapsible")}
+      phx-click="toggle-collapsible"
       phx-value-trace-id={@trace_display.id}
+      phx-value-render-body={@trace_display.render_body?}
     >
       <:label>
         <%= render_slot(@label) %>
@@ -96,7 +97,9 @@ defmodule LiveDebugger.App.Debugger.CallbackTracing.Web.HookComponents.TraceWrap
     |> halt()
   end
 
-  defp handle_event("toggle-collapsible", %{"trace-id" => string_trace_id}, socket) do
+  defp handle_event("toggle-collapsible", %{"trace-id" => string_trace_id} = params, socket) do
+    render_body? = Map.has_key?(params, "render-body")
+
     socket
     |> get_trace(string_trace_id)
     |> case do
@@ -105,7 +108,7 @@ defmodule LiveDebugger.App.Debugger.CallbackTracing.Web.HookComponents.TraceWrap
         socket
 
       trace ->
-        stream_insert_trace(socket, trace)
+        stream_insert_trace(socket, trace, !render_body?)
     end
     |> halt()
   end
@@ -133,11 +136,11 @@ defmodule LiveDebugger.App.Debugger.CallbackTracing.Web.HookComponents.TraceWrap
     )
   end
 
-  defp stream_insert_trace(socket, trace) do
+  defp stream_insert_trace(socket, trace, render_body?) do
     stream_insert(
       socket,
       :existing_traces,
-      trace |> TraceDisplay.from_trace() |> TraceDisplay.render_body()
+      trace |> TraceDisplay.from_trace() |> TraceDisplay.render_body(render_body?)
     )
   end