Skip to content

Commit 3e3734b

Browse files
authored
chore: RN 0.84 (#414)
# Summary Upgrades example app to RN 0.84 ## Test Plan - Ensure lib builds fine - Ensure example app runs fine ## Screenshots / Videos n/a ## Compatibility | OS | Implemented | | ------- | :---------: | | iOS | ✅ | | Android | ✅ |
1 parent ce62e31 commit 3e3734b

File tree

9 files changed

+997
-2014
lines changed

9 files changed

+997
-2014
lines changed

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v20.19.0
1+
v22.12.0

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ We can help you build your next dream product –
4040
## Prerequisites
4141

4242
- `react-native-enriched` currently supports only Android and iOS platforms
43-
- It works only with [the React Native New Architecture (Fabric)](https://reactnative.dev/architecture/landing-page) and supports following React Native releases: `0.79`, `0.80`, `0.81`, `0.82` and `0.83`
43+
- It works only with [the React Native New Architecture (Fabric)](https://reactnative.dev/architecture/landing-page) and supports following React Native releases: `0.79`, `0.80`, `0.81`, `0.82`, `0.83` and `0.84`.
4444

4545
## Installation
4646

apps/example/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ react {
1919

2020
/* Variants */
2121
// The list of variants to that are debuggable. For those we're going to
22-
// skip the bundling of the JS bundle and the assets. By default is just 'debug'.
22+
// skip the bundling of the JS bundle and the assets. Default is "debug", "debugOptimized".
2323
// If you add flavors like lite, prod, etc. you'll have to list your debuggableVariants.
24-
// debuggableVariants = ["liteDebug", "prodDebug"]
24+
// debuggableVariants = ["liteDebug", "liteDebugOptimized", "prodDebug", "prodDebugOptimized"]
2525

2626
/* Bundling */
2727
// A list containing the node command and its flags. Default is just 'node'.

apps/example/ios/EnrichedTextInputExample.xcodeproj/project.pbxproj

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,8 +428,10 @@
428428
);
429429
PRODUCT_BUNDLE_IDENTIFIER = swmansion.enrichedtextinputexample.example;
430430
PRODUCT_NAME = EnrichedTextInputExample;
431+
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
431432
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
432433
SWIFT_VERSION = 5.0;
434+
TARGETED_DEVICE_FAMILY = "1,2";
433435
VERSIONING_SYSTEM = "apple-generic";
434436
};
435437
name = Debug;
@@ -455,7 +457,9 @@
455457
);
456458
PRODUCT_BUNDLE_IDENTIFIER = swmansion.enrichedtextinputexample.example;
457459
PRODUCT_NAME = EnrichedTextInputExample;
460+
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
458461
SWIFT_VERSION = 5.0;
462+
TARGETED_DEVICE_FAMILY = "1,2";
459463
VERSIONING_SYSTEM = "apple-generic";
460464
};
461465
name = Release;
@@ -521,14 +525,18 @@
521525
);
522526
MTL_ENABLE_DEBUG_INFO = YES;
523527
ONLY_ACTIVE_ARCH = YES;
524-
OTHER_CFLAGS = "$(inherited)";
528+
OTHER_CFLAGS = (
529+
"$(inherited)",
530+
"-DRCT_REMOVE_LEGACY_ARCH=1",
531+
);
525532
OTHER_CPLUSPLUSFLAGS = (
526533
"$(OTHER_CFLAGS)",
527534
"-DFOLLY_NO_CONFIG",
528535
"-DFOLLY_MOBILE=1",
529536
"-DFOLLY_USE_LIBCPP=1",
530537
"-DFOLLY_CFG_NO_COROUTINES=1",
531538
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
539+
"-DRCT_REMOVE_LEGACY_ARCH=1",
532540
);
533541
OTHER_LDFLAGS = (
534542
"$(inherited)",
@@ -537,6 +545,7 @@
537545
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
538546
SDKROOT = iphoneos;
539547
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) DEBUG";
548+
SWIFT_ENABLE_EXPLICIT_MODULES = NO;
540549
USE_HERMES = true;
541550
};
542551
name = Debug;
@@ -594,21 +603,26 @@
594603
"\"$(inherited)\"",
595604
);
596605
MTL_ENABLE_DEBUG_INFO = NO;
597-
OTHER_CFLAGS = "$(inherited)";
606+
OTHER_CFLAGS = (
607+
"$(inherited)",
608+
"-DRCT_REMOVE_LEGACY_ARCH=1",
609+
);
598610
OTHER_CPLUSPLUSFLAGS = (
599611
"$(OTHER_CFLAGS)",
600612
"-DFOLLY_NO_CONFIG",
601613
"-DFOLLY_MOBILE=1",
602614
"-DFOLLY_USE_LIBCPP=1",
603615
"-DFOLLY_CFG_NO_COROUTINES=1",
604616
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
617+
"-DRCT_REMOVE_LEGACY_ARCH=1",
605618
);
606619
OTHER_LDFLAGS = (
607620
"$(inherited)",
608621
" ",
609622
);
610623
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
611624
SDKROOT = iphoneos;
625+
SWIFT_ENABLE_EXPLICIT_MODULES = NO;
612626
USE_HERMES = true;
613627
VALIDATE_PRODUCT = YES;
614628
};

0 commit comments

Comments
 (0)