Skip to content

Commit 87c33d9

Browse files
authored
Fix macos newarch flag
## Description MacOS app did not find methods declared in `RNGestureHandlerModules`. This PR fixes this issue by setting `:new_arch_enabled` flag in the podfile to true. ## Test plan Launch MacOS example
1 parent d4b7ebe commit 87c33d9

File tree

2 files changed

+136
-11
lines changed

2 files changed

+136
-11
lines changed

apps/macos-example/macos/Podfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ target 'MacOSExample-macOS' do
1616
use_react_native!(
1717
:path => '../node_modules/react-native-macos',
1818
:hermes_enabled => false,
19-
:fabric_enabled => ENV['RCT_NEW_ARCH_ENABLED'] == '1',
2019
# An absolute path to your application root.
21-
:app_path => "#{Pod::Config.instance.installation_root}/.."
20+
:app_path => "#{Pod::Config.instance.installation_root}/..",
21+
:new_arch_enabled => true
2222
)
2323

2424
post_install do |installer|

apps/macos-example/macos/Podfile.lock

Lines changed: 134 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1210,7 +1210,71 @@ PODS:
12101210
- React-RCTFBReactNativeSpec
12111211
- ReactCommon/turbomodule/core
12121212
- react-native-safe-area-context (5.4.0):
1213+
- DoubleConversion
1214+
- glog
1215+
- RCT-Folly (= 2024.11.18.00)
1216+
- RCTRequired
1217+
- RCTTypeSafety
1218+
- React-Core
1219+
- React-debug
1220+
- React-Fabric
1221+
- React-featureflags
1222+
- React-graphics
1223+
- React-ImageManager
1224+
- React-jsi
1225+
- react-native-safe-area-context/common (= 5.4.0)
1226+
- react-native-safe-area-context/fabric (= 5.4.0)
1227+
- React-NativeModulesApple
1228+
- React-RCTFabric
1229+
- React-rendererdebug
1230+
- React-utils
1231+
- ReactCodegen
1232+
- ReactCommon/turbomodule/bridging
1233+
- ReactCommon/turbomodule/core
1234+
- Yoga
1235+
- react-native-safe-area-context/common (5.4.0):
1236+
- DoubleConversion
1237+
- glog
1238+
- RCT-Folly (= 2024.11.18.00)
1239+
- RCTRequired
1240+
- RCTTypeSafety
12131241
- React-Core
1242+
- React-debug
1243+
- React-Fabric
1244+
- React-featureflags
1245+
- React-graphics
1246+
- React-ImageManager
1247+
- React-jsi
1248+
- React-NativeModulesApple
1249+
- React-RCTFabric
1250+
- React-rendererdebug
1251+
- React-utils
1252+
- ReactCodegen
1253+
- ReactCommon/turbomodule/bridging
1254+
- ReactCommon/turbomodule/core
1255+
- Yoga
1256+
- react-native-safe-area-context/fabric (5.4.0):
1257+
- DoubleConversion
1258+
- glog
1259+
- RCT-Folly (= 2024.11.18.00)
1260+
- RCTRequired
1261+
- RCTTypeSafety
1262+
- React-Core
1263+
- React-debug
1264+
- React-Fabric
1265+
- React-featureflags
1266+
- React-graphics
1267+
- React-ImageManager
1268+
- React-jsi
1269+
- react-native-safe-area-context/common
1270+
- React-NativeModulesApple
1271+
- React-RCTFabric
1272+
- React-rendererdebug
1273+
- React-utils
1274+
- ReactCodegen
1275+
- ReactCommon/turbomodule/bridging
1276+
- ReactCommon/turbomodule/core
1277+
- Yoga
12141278
- React-NativeModulesApple (0.78.4):
12151279
- glog
12161280
- React-callinvoker
@@ -1483,7 +1547,26 @@ PODS:
14831547
- React-perflogger (= 0.78.4)
14841548
- React-utils (= 0.78.4)
14851549
- RNCAsyncStorage (2.1.2):
1550+
- DoubleConversion
1551+
- glog
1552+
- RCT-Folly (= 2024.11.18.00)
1553+
- RCTRequired
1554+
- RCTTypeSafety
14861555
- React-Core
1556+
- React-debug
1557+
- React-Fabric
1558+
- React-featureflags
1559+
- React-graphics
1560+
- React-ImageManager
1561+
- React-jsi
1562+
- React-NativeModulesApple
1563+
- React-RCTFabric
1564+
- React-rendererdebug
1565+
- React-utils
1566+
- ReactCodegen
1567+
- ReactCommon/turbomodule/bridging
1568+
- ReactCommon/turbomodule/core
1569+
- Yoga
14871570
- RNGestureHandler (2.28.0):
14881571
- DoubleConversion
14891572
- glog
@@ -1615,7 +1698,48 @@ PODS:
16151698
- ReactCommon/turbomodule/core
16161699
- Yoga
16171700
- RNSVG (15.11.2):
1701+
- DoubleConversion
1702+
- glog
1703+
- RCT-Folly (= 2024.11.18.00)
1704+
- RCTRequired
1705+
- RCTTypeSafety
1706+
- React-Core
1707+
- React-debug
1708+
- React-Fabric
1709+
- React-featureflags
1710+
- React-graphics
1711+
- React-ImageManager
1712+
- React-jsi
1713+
- React-NativeModulesApple
1714+
- React-RCTFabric
1715+
- React-rendererdebug
1716+
- React-utils
1717+
- ReactCodegen
1718+
- ReactCommon/turbomodule/bridging
1719+
- ReactCommon/turbomodule/core
1720+
- RNSVG/common (= 15.11.2)
1721+
- Yoga
1722+
- RNSVG/common (15.11.2):
1723+
- DoubleConversion
1724+
- glog
1725+
- RCT-Folly (= 2024.11.18.00)
1726+
- RCTRequired
1727+
- RCTTypeSafety
16181728
- React-Core
1729+
- React-debug
1730+
- React-Fabric
1731+
- React-featureflags
1732+
- React-graphics
1733+
- React-ImageManager
1734+
- React-jsi
1735+
- React-NativeModulesApple
1736+
- React-RCTFabric
1737+
- React-rendererdebug
1738+
- React-utils
1739+
- ReactCodegen
1740+
- ReactCommon/turbomodule/bridging
1741+
- ReactCommon/turbomodule/core
1742+
- Yoga
16191743
- SocketRocket (0.7.1)
16201744
- Yoga (0.0.0)
16211745

@@ -1649,6 +1773,7 @@ DEPENDENCIES:
16491773
- React-idlecallbacksnativemodule (from `../node_modules/react-native-macos/ReactCommon/react/nativemodule/idlecallbacks`)
16501774
- React-ImageManager (from `../node_modules/react-native-macos/ReactCommon/react/renderer/imagemanager/platform/ios`)
16511775
- React-jsc (from `../node_modules/react-native-macos/ReactCommon/jsc`)
1776+
- React-jsc/Fabric (from `../node_modules/react-native-macos/ReactCommon/jsc`)
16521777
- React-jserrorhandler (from `../node_modules/react-native-macos/ReactCommon/jserrorhandler`)
16531778
- React-jsi (from `../node_modules/react-native-macos/ReactCommon/jsi`)
16541779
- React-jsiexecutor (from `../node_modules/react-native-macos/ReactCommon/jsiexecutor`)
@@ -1872,16 +1997,16 @@ SPEC CHECKSUMS:
18721997
React-logger: 7710d15dff02b5cf12f74c64f7fc07d3d0ed35a8
18731998
React-Mapbuffer: eae1ba319b99b32da165269bfeea4ae5923f9e09
18741999
React-microtasksnativemodule: 1ac5c0eb9461aeb4a8ae6d264ed463fa1183ecde
1875-
react-native-safe-area-context: 9d72abf6d8473da73033b597090a80b709c0b2f1
2000+
react-native-safe-area-context: 35ad50501de86ff63b51709735ebfa012b00f0d1
18762001
React-NativeModulesApple: c1f7efd2131cde7c2b4a8405447dbe48eb8411e9
18772002
React-perflogger: 258d7a5191bf8eb541a6441234cd9ce8d3cfa08e
18782003
React-performancetimeline: 68314836dc1ea3cacae38bd43d80ee5116a423bf
18792004
React-RCTActionSheet: 9618e6d1a0c5270801c0b01fb85b91259ae9bf1c
18802005
React-RCTAnimation: 354b6f0e127038892f86d04b1d08ba14678da282
1881-
React-RCTAppDelegate: ed5d22102427ba8fcc9e8d3a678394d1e20bef84
2006+
React-RCTAppDelegate: a9ac893453831d6529330ff5e6990f236841ad1d
18822007
React-RCTBlob: 08edc5e6f168bbc0b3f972af19c57027cbfd41e4
1883-
React-RCTFabric: 0104b278f3afe1c2778de6ac7a5b7a82bdb1b488
1884-
React-RCTFBReactNativeSpec: 53a80cd8ac923d76792c21fac336ebd1782320cb
2008+
React-RCTFabric: f869385817b97ad531056aa073d3c119297f32e5
2009+
React-RCTFBReactNativeSpec: 22f3364aa043eb8cc0f7c2eaf2cde3242a8c2187
18852010
React-RCTImage: 2ad45f2da96fa8be00bc859c0441d4ad98ee74e5
18862011
React-RCTLinking: 87fdc9bcb872563502daadc073922bd957268f7e
18872012
React-RCTNetwork: 465f3d9e6168ccaad96f5da05cc9182845f4bbcc
@@ -1900,13 +2025,13 @@ SPEC CHECKSUMS:
19002025
ReactAppDependencyProvider: 93ba70597920a832aaa2c0dad33ddcafb70254f1
19012026
ReactCodegen: a69b3fe94242a2d03ceebfc2a2b9eb634ddbb0ec
19022027
ReactCommon: d8a297276a8a494803194d834d5ee331c6be176c
1903-
RNCAsyncStorage: b9f5f78da5d16a853fe3dc22e8268d932fc45a83
1904-
RNGestureHandler: 2b38b08d00b5328a167369db72fac42e6063bfd3
1905-
RNReanimated: 2f4006248cb13f20cd2510e906e591afa54ef5bd
1906-
RNSVG: 4c63b12b7b5761063bca4f20dd228f6a8370f614
2028+
RNCAsyncStorage: f87e7905ae8a3ee95a69f4bd7046fcaaf8e46f13
2029+
RNGestureHandler: 017cf108ddcd44afe62f725c6923e5dea87a6edf
2030+
RNReanimated: 4770f6d1e066eb2d8a20e3d3c8e4b3997b6cd251
2031+
RNSVG: c46446a6250639d369ec1e39bc4d8284984bb330
19072032
SocketRocket: 03f7111df1a343b162bf5b06ead333be808e1e0a
19082033
Yoga: 68988998b6d10a0802dd7d5c6d40bf018e09ffd9
19092034

1910-
PODFILE CHECKSUM: ba6f2105d3e43bf0ae77356a9afcc8b532e3c306
2035+
PODFILE CHECKSUM: 753d3d7d386258a325dca769aa778dc6a0cb56b4
19112036

19122037
COCOAPODS: 1.15.2

0 commit comments

Comments
 (0)