Compatibility with new Hermes (#8268)

## Summary

Starting with React Native 0.82, it will be possible to test the new
version of Hermes v1 (previously called Static Hermes) by enabling the
flag `HERMES_V1_ENABLED`—see more details here:
[link](facebook/react-native#53579). Reanimated
works with new Hermes out of the box; we just need to stop using the
legacy debugger with the new Hermes, as it removes them.

We're working on supporting the new debugger, but it will require more
attention—follow the progress here:
[link](#7655).

## Test plan

Author: piaskowyk

packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/WorkletHermesRuntime.cpp

@@ -16,13 +16,17 @@ namespace worklets {
 
 using namespace facebook;
 using namespace react;
-#if HERMES_ENABLE_DEBUGGER
+#if HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
 using namespace facebook::hermes::inspector_modern;
-#endif // HERMES_ENABLE_DEBUGGER
+#endif // HERMES_ENABLE_DEBUGGER  && !defined(HERMES_V1_ENABLED)
 
 #if HERMES_ENABLE_DEBUGGER
 
-class HermesExecutorRuntimeAdapter : public RuntimeAdapter {
+class HermesExecutorRuntimeAdapter
+#if HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
+    : public RuntimeAdapter
+#endif // HERMES_ENABLE_DEBUGGER  && !defined(HERMES_V1_ENABLED)
+{
  public:
   explicit HermesExecutorRuntimeAdapter(
       facebook::hermes::HermesRuntime &hermesRuntime,
@@ -34,7 +38,7 @@ class HermesExecutorRuntimeAdapter : public RuntimeAdapter {
     // that the thread was indeed `quit` before
     thread_->quitSynchronous();
   }
-
+#if HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
   facebook::hermes::HermesRuntime &getRuntime() override {
     return hermesRuntime_;
   }
@@ -44,6 +48,7 @@ class HermesExecutorRuntimeAdapter : public RuntimeAdapter {
   // required us to hold a refernce to the runtime inside this adapter which
   // caused issues while reloading the app.
   void tickleJs() override {}
+#endif // HERMES_ENABLE_DEBUGGER  && !defined(HERMES_V1_ENABLED)
 
  public:
   facebook::hermes::HermesRuntime &hermesRuntime_;
@@ -60,11 +65,11 @@ WorkletHermesRuntime::WorkletHermesRuntime(
           *runtime,
           reentrancyCheck_),
       runtime_(std::move(runtime)) {
-#if HERMES_ENABLE_DEBUGGER
+#if HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
   auto adapter =
       std::make_unique<HermesExecutorRuntimeAdapter>(*runtime_, jsQueue);
   debugToken_ = chrome::enableDebugging(std::move(adapter), name);
-#endif // HERMES_ENABLE_DEBUGGER
+#endif // HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
 
 #ifndef NDEBUG
   facebook::hermes::HermesRuntime *wrappedRuntime = runtime_.get();
@@ -97,10 +102,10 @@ WorkletHermesRuntime::WorkletHermesRuntime(
 }
 
 WorkletHermesRuntime::~WorkletHermesRuntime() {
-#if HERMES_ENABLE_DEBUGGER
+#if HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
   // We have to disable debugging before the runtime is destroyed.
   chrome::disableDebugging(debugToken_);
-#endif // HERMES_ENABLE_DEBUGGER
+#endif // HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
 }
 
 } // namespace worklets

packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/WorkletHermesRuntime.h

@@ -17,17 +17,17 @@
 #include <string>
 #include <thread>
 
-#if HERMES_ENABLE_DEBUGGER
+#if HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
 #include <hermes/inspector-modern/chrome/Registration.h>
-#endif // HERMES_ENABLE_DEBUGGER
+#endif // HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
 
 namespace worklets {
 
 using namespace facebook;
 using namespace react;
-#if HERMES_ENABLE_DEBUGGER
+#if HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
 using namespace facebook::hermes::inspector_modern;
-#endif // HERMES_ENABLE_DEBUGGER
+#endif // HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
 
 // ReentrancyCheck is copied from React Native
 // from ReactCommon/hermes/executor/HermesExecutorFactory.cpp
@@ -121,9 +121,9 @@ class WorkletHermesRuntime
  private:
   std::unique_ptr<facebook::hermes::HermesRuntime> runtime_;
   WorkletsReentrancyCheck reentrancyCheck_;
-#if HERMES_ENABLE_DEBUGGER
+#if HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
   chrome::DebugSessionToken debugToken_;
-#endif // HERMES_ENABLE_DEBUGGER
+#endif // HERMES_ENABLE_DEBUGGER && !defined(HERMES_V1_ENABLED)
 };
 
 } // namespace worklets

packages/react-native-worklets/android/CMakeLists.txt

@@ -15,8 +15,9 @@ string(
   APPEND
   CMAKE_CXX_FLAGS
   " -DREACT_NATIVE_MINOR_VERSION=${REACT_NATIVE_MINOR_VERSION}\
-         -DWORKLETS_VERSION=${WORKLETS_VERSION}\
-         -DWORKLETS_FEATURE_FLAGS=\"${WORKLETS_FEATURE_FLAGS}\"")
+    -DWORKLETS_VERSION=${WORKLETS_VERSION}\
+    -DWORKLETS_FEATURE_FLAGS=\"${WORKLETS_FEATURE_FLAGS}\"\
+    -DHERMES_V1_ENABLED=${HERMES_V1_ENABLED}")
 
 string(APPEND CMAKE_CXX_FLAGS " -fno-omit-frame-pointer -fstack-protector-all")
 

packages/react-native-worklets/android/build.gradle

@@ -102,6 +102,7 @@ def IS_NEW_ARCHITECTURE_ENABLED = isNewArchitectureEnabled()
 def IS_REANIMATED_EXAMPLE_APP = safeAppExtGet("isReanimatedExampleApp", false)
 def BUNDLE_MODE = safeAppExtGet("workletsBundleMode", false)
 def WORKLETS_FEATURE_FLAGS = getStaticFeatureFlags()
+def HERMES_V1_ENABLED = safeAppExtGet("hermesV1Enabled", false)
 
 // Set version for prefab
 version WORKLETS_VERSION
@@ -196,7 +197,8 @@ android {
                         "-DWORKLETS_BUNDLE_MODE=${BUNDLE_MODE}",
                         "-DWORKLETS_VERSION=${WORKLETS_VERSION}",
                         "-DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON",
-                        "-DWORKLETS_FEATURE_FLAGS=${WORKLETS_FEATURE_FLAGS}"
+                        "-DWORKLETS_FEATURE_FLAGS=${WORKLETS_FEATURE_FLAGS}",
+                        "-DHERMES_V1_ENABLED=${HERMES_V1_ENABLED}"
                 abiFilters (*reactNativeArchitectures())
                 targets("worklets")
             }