Curious about the typescript TODOS #6478
Unanswered
ugurcanatas
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hello ✋
Recently, i was using
withSpring
in 4 different places but with a same spring config basically.Then i tried to import the
SpringConfig
type but i guess this is not exported properly.I was trying to do something like this:
but ended up doing ⏬ for now
While inspecting the code, i saw that there are couple TODO comments:
// TODO TYPESCRIPT This is temporary type put in here to get rid of our .d.ts file
Is there a plan for how to integrate this TODO because i was planning on creating a PR to export
SpringConfig
but after looking at the TODO comment i was hesitant. it seems like there is a plan for this in the future.And also, is it fine to export SprintConfig just as similarly done in
timing.ts
file in a PR?Thanks!
Beta Was this translation helpful? Give feedback.
All reactions