Potential numeric precision loss in Snapshot.java - CodeQL alert

[unstoo]

Hi Reanimated team,

I received a CodeQL security/static analysis alert in my project regarding potential numeric precision loss in:
node_modules/react-native-reanimated/android/src/main/java/com/swmansion/reanimated/layoutReanimation/Snapshot.java:127

The alert suggests that there might be an implicit narrowing conversion when accumulating float values (from getX()) into an integer variable using compound assignment (+=).

I wanted to check with the maintainers:

1. Is this intentional (e.g., for performance or because sub-pixel precision isn't needed)?
2. Could this cause any issues in certain edge cases?
3. If this is a valid concern, would you be interested in a PR to address it?

Thank you for your time and clarification!

[MatiPl01]

Hey @unstoo!

Thanks for asking about that.

I don't think we would bother about this. I haven't seen any complaints related to imprecise layout animation because of narrowing value conversions and sub-pixel precision doesn't seem to be needed.

We also don't plan to make any major changes to the Old Architecture related code. The New Architecture implementation is rewritten in CPP and is shared between Android and iOS, so we don't plan to add any changes to this java code (except fixing bugs).

Since this narrowing conversion doesn't seem to be a problem, I think that there is no point in changing this code.

[unstoo]

Thank you for the clarification 👍