feat: Trigger CSS transitions from JS without the use of StaticPropsRegistry in C++ #8656
+916
−1,065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiPl01
changed the title
MatiPl01
force-pushed
the
@matipl01/css-transfroms-core-reimplementation
branch
from
53325bb to
8bd9207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removed the use of the
StaticPropsRegistryin CSS transitions. It also removes the props observing and diffing mechanism from C++ and moves it to JS in order to get rid of theStaticPropsRegistryin the near future (and then get rid of registries that store latest updates from CSS transitions).Test plan
Go through CSS transition examples in the example app
TODO