fix nonull, noop and RNSLog

Author: kmichalikk

ios/gamma/stack/host/RNSStackHostComponentView.mm

@@ -82,11 +82,10 @@ - (void)stackScreenChangedActivityMode:(nonnull RNSStackScreenComponentView *)st
 
 - (void)mountChildComponentView:(UIView<RCTComponentViewProtocol> *)childComponentView index:(NSInteger)index
 {
-  RCTAssert(
-      [childComponentView isKindOfClass:RNSStackScreenComponentView.class],
-      @"[RNScreens] Attempt to mount child of unsupported type: %@, expected %@",
-      childComponentView.class,
-      RNSStackScreenComponentView.class);
+  RCTAssert([childComponentView isKindOfClass:RNSStackScreenComponentView.class],
+            @"[RNScreens] Attempt to mount child of unsupported type: %@, expected %@",
+            childComponentView.class,
+            RNSStackScreenComponentView.class);
 
   auto *childScreen = static_cast<RNSStackScreenComponentView *>(childComponentView);
   childScreen.stackHost = self;
@@ -103,11 +102,10 @@ - (void)addPushOperationIfNeeded:(nonnull RNSStackScreenComponentView *)stackScr
 
 - (void)unmountChildComponentView:(UIView<RCTComponentViewProtocol> *)childComponentView index:(NSInteger)index
 {
-  RCTAssert(
-      [childComponentView isKindOfClass:RNSStackScreenComponentView.class],
-      @"[RNScreens] Attempt to unmount child of unsupported type: %@, expected %@",
-      childComponentView.class,
-      RNSStackScreenComponentView.class);
+  RCTAssert([childComponentView isKindOfClass:RNSStackScreenComponentView.class],
+            @"[RNScreens] Attempt to unmount child of unsupported type: %@, expected %@",
+            childComponentView.class,
+            RNSStackScreenComponentView.class);
 
   auto *childScreen = static_cast<RNSStackScreenComponentView *>(childComponentView);
   [_renderedScreens removeObject:childScreen];
@@ -121,9 +119,8 @@ - (void)addPopOperationIfNeeded:(nonnull RNSStackScreenComponentView *)stackScre
     // This shouldn't happen in typical scenarios but it can happen with fast-refresh.
     [_stackOperationCoordinator addPopOperation:stackScreen];
   } else {
-    RNSLog(
-        @"[RNScreens] ignoring pop operation of %s, already not attached or natively dismissed",
-        [stackScreen.screenKey cStringUsingEncoding:NSUTF8StringEncoding]);
+    RNSLog(@"[RNScreens] ignoring pop operation of %s, already not attached or natively dismissed",
+           [stackScreen.screenKey cStringUsingEncoding:NSUTF8StringEncoding]);
   }
 }
 
@@ -141,12 +138,6 @@ + (BOOL)shouldBeRecycled
 
 #pragma mark - RCTMountingTransactionObserving
 
-- (void)mountingTransactionWillMount:(const facebook::react::MountingTransaction &)transaction
-                withSurfaceTelemetry:(const facebook::react::SurfaceTelemetry &)surfaceTelemetry
-{
-  // noop
-}
-
 - (void)mountingTransactionDidMount:(const facebook::react::MountingTransaction &)transaction
                withSurfaceTelemetry:(const facebook::react::SurfaceTelemetry &)surfaceTelemetry
 {

ios/gamma/stack/host/RNSStackOperation.h

@@ -6,21 +6,21 @@ NS_ASSUME_NONNULL_BEGIN
 
 @protocol RNSStackOperation
 
-@property (nonatomic, strong, readonly, nonnull) RNSStackScreenComponentView *stackScreen;
+@property (nonatomic, strong, readonly) RNSStackScreenComponentView *stackScreen;
 
 @end
 
 @interface RNSPushOperation : NSObject <RNSStackOperation>
 
-@property (nonatomic, strong, readonly, nonnull) RNSStackScreenComponentView *stackScreen;
+@property (nonatomic, strong, readonly) RNSStackScreenComponentView *stackScreen;
 
 - (instancetype)initWithScreen:(nonnull RNSStackScreenComponentView *)stackScreen;
 
 @end
 
 @interface RNSPopOperation : NSObject <RNSStackOperation>
 
-@property (nonatomic, strong, readonly, nonnull) RNSStackScreenComponentView *stackScreen;
+@property (nonatomic, strong, readonly) RNSStackScreenComponentView *stackScreen;
 
 - (instancetype)initWithScreen:(nonnull RNSStackScreenComponentView *)stackScreen;
 

ios/gamma/stack/screen/RNSStackScreenController.mm

@@ -1,4 +1,5 @@
 #import "RNSStackScreenController.h"
+#import "RNSLog.h"
 #import "RNSStackHostComponentView.h"
 #import "RNSStackNavigationController.h"
 #import "RNSStackScreenComponentEventEmitter.h"
@@ -54,7 +55,7 @@ - (void)viewDidDisappear:(BOOL)animated
 
 - (void)didMoveToParentViewController:(UIViewController *)parent
 {
-  NSLog(@"[RNScreens] Screen view with tag=%ld didMoveToParentViewController %@", (long)_screenView.tag, parent);
+  RNSLog(@"[RNScreens] Screen view with tag=%ld didMoveToParentViewController %@", (long)_screenView.tag, parent);
   [super didMoveToParentViewController:parent];
 
   if (parent == nil) {