Commit 5359e4e
fix(iOS): FullWindowOverlay layout height (#2430)
## Description
This PR intents to fix `FullWindowOverlay`s height issue.
The component is given wrong frame size during layout because of it's
placement in the react tree. Although in the iOS view hierarchy it is
displayed independently its height is still reduced by the height of the
header.
Correct frame can be achieved by utilising `useWindowDimensions` hook
and forcing correct width and height on the JS side.
Fixes #1247
## Changes
- modified `Test1096` repro
## Screenshots / GIFs
### Before

### After

## Test code and steps to reproduce
- use `Test1096` repro
## Checklist
- [x] Included code example that can be used to test this change
- [x] Ensured that CI passes
(cherry picked from commit cf31492)1 parent dc8c058 commit 5359e4e
File tree
2 files changed
+17
-6
lines changed- apps/src/tests
- src/components
2 files changed
+17
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | | - | |
39 | | - | |
| 37 | + | |
40 | 38 | | |
41 | 39 | | |
42 | 40 | | |
| |||
80 | 78 | | |
81 | 79 | | |
82 | 80 | | |
83 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
84 | 87 | | |
85 | 88 | | |
86 | 89 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
3 | 10 | | |
4 | 11 | | |
5 | 12 | | |
| |||
10 | 17 | | |
11 | 18 | | |
12 | 19 | | |
| 20 | + | |
13 | 21 | | |
14 | 22 | | |
15 | 23 | | |
16 | 24 | | |
17 | 25 | | |
18 | 26 | | |
19 | | - | |
| 27 | + | |
20 | 28 | | |
21 | 29 | | |
22 | 30 | | |
| |||
0 commit comments