Commit 68e3d73
authored
fix(iOS,Paper): fix broken modal go-back animation (#2496)
## Description
We recently fixed left-out modals dismissal when reloading react-native.
For some reason
calling in `dismissViewControllerAnimated:completion:` on **nested**
UINavigationController
(the one responsible for displaying the navigation bar in modal, not the
one reponsible for presentation)
during invalidation messes up with the animation.
I'm not really sure why this is the case. Earlier we were calling
dismiss on all presented modals,
but not on UINavigationController itself and it worked like a charm.
I've found out that simply animating the change solves the situation -
we fix the animation and keep nice
modal dismissal on reload.
Fixes #2488
## Changes
:point_up:
## Test code and steps to reproduce
`TestModalNavigation`
## Checklist
- [ ] Included code example that can be used to test this change
- [ ] Updated TS types
- [ ] Updated documentation: <!-- For adding new props to native-stack
-->
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx
- [ ]
https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx
- [ ] Ensured that CI passes1 parent b84fd63 commit 68e3d73
2 files changed
+10
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
28 | 32 | | |
29 | | - | |
| 33 | + | |
30 | 34 | | |
31 | 35 | | |
32 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
33 | 41 | | |
34 | 42 | | |
35 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1288 | 1288 | | |
1289 | 1289 | | |
1290 | 1290 | | |
1291 | | - | |
| 1291 | + | |
1292 | 1292 | | |
1293 | 1293 | | |
1294 | 1294 | | |
| |||
0 commit comments