apply suggestions

Author: kligarski

ios/RNSScreen.mm

@@ -1995,6 +1995,7 @@ - (void)presentViewController:(UIViewController *)viewControllerToPresent
 }
 
 #pragma mark - RNSOrientationProviding
+
 - (RNSOrientation)evaluateOrientation
 {
   return rnscreens::conversion::RNSOrientationFromUIInterfaceOrientationMask([self supportedInterfaceOrientations]);

ios/bottom-tabs/RNSTabBarController.h

@@ -59,7 +59,7 @@ NS_ASSUME_NONNULL_BEGIN
 /**
  * Find out which tab bar controller is currently focused & select it.
  *
- * This method does nothing if the update has not been previoulsy requested.
+ * This method does nothing if the update has not been previously requested.
  * If needed, the requested update is performed immediately. If you do not need this, consider just raising an
  * appropriate invalidation signal & let the controller decide when to flush the updates.
  */
@@ -76,7 +76,7 @@ NS_ASSUME_NONNULL_BEGIN
 /**
  * Updates the tab bar appearance basing on configuration sources (host view, tab screens).
  *
- * This method does nothing if the update has not been previoulsy requested.
+ * This method does nothing if the update has not been previously requested.
  * If needed, the requested update is performed immediately. If you do not need this, consider just raising an
  * appropriate invalidation signal & let the controller decide when to flush the updates.
  */
@@ -93,7 +93,7 @@ NS_ASSUME_NONNULL_BEGIN
 /**
  * Updates the interface orientation based on selected tab screen and its children.
  *
- * This method does nothing if the update has not been previoulsy requested.
+ * This method does nothing if the update has not been previously requested.
  * If needed, the requested update is performed immediately. If you do not need this, consider just raising an
  * appropriate invalidation signal & let the controller decide when to flush the updates.
  */
@@ -119,23 +119,23 @@ NS_ASSUME_NONNULL_BEGIN
 
 /**
  * Tell the controller that react provided tabs have changed (count / instances) & the child view controllers need to be
- * udpated.
+ * updated.
  *
  * This also automatically raises `needsReactChildrenUpdate` flag, no need to call it manually.
  */
 - (void)childViewControllersHaveChangedTo:(nonnull NSArray<RNSTabsScreenViewController *> *)childViewControllers;
 
 /**
  * Tell the controller that react provided tabs have changed (count / instances) & the child view controllers need to be
- * udpated.
+ * updated.
  *
  * Do not raise this signal only when focused state of the tab has changed - use `needsSelectedTabUpdate` instead.
  */
 @property (nonatomic, readwrite) bool needsUpdateOfReactChildrenControllers;
 
 /**
  * Tell the controller that react provided tabs have changed (count / instances) & the child view controllers need to be
- * udpated.
+ * updated.
  */
 @property (nonatomic, readwrite) bool needsUpdateOfSelectedTab;
 
@@ -148,7 +148,7 @@ NS_ASSUME_NONNULL_BEGIN
 /**
  * Tell the controller that some configuration regarding interface orientation has changed & it requires update.
  */
-@property (nonatomic, readwrite) bool needsUpdateOfOrientation;
+@property (nonatomic, readwrite) bool needsOrientationUpdate;
 
 @end
 

ios/bottom-tabs/RNSTabBarController.mm

@@ -71,9 +71,9 @@ - (void)setNeedsUpdateOfTabBarAppearance:(bool)needsUpdateOfTabBarAppearance
 #endif // !RCT_NEW_ARCH_ENABLED
 }
 
-- (void)setNeedsUpdateOfOrientation:(bool)needsUpdateOfOrientation
+- (void)setNeedsOrientationUpdate:(bool)needsOrientationUpdate
 {
-  _needsUpdateOfOrientation = needsUpdateOfOrientation;
+  _needsOrientationUpdate = needsOrientationUpdate;
 }
 
 #pragma mark-- RNSReactTransactionObserving
@@ -213,7 +213,7 @@ - (void)scheduleControllerUpdateIfNeeded
 
 - (void)updateOrientationIfNeeded
 {
-  if (_needsUpdateOfOrientation) {
+  if (_needsOrientationUpdate) {
     [self updateOrientation];
   }
 }
@@ -224,6 +224,7 @@ - (void)updateOrientation
 }
 
 #pragma mark - RNSOrientationProviding
+
 - (RNSOrientation)evaluateOrientation
 {
   if ([self.selectedViewController respondsToSelector:@selector(evaluateOrientation)]) {

ios/bottom-tabs/RNSTabsScreenViewController.mm

@@ -34,7 +34,7 @@ - (void)tabItemAppearanceHasChanged
 
 - (void)tabScreenOrientationHasChanged
 {
-  [[self findTabBarController] setNeedsUpdateOfOrientation:true];
+  [[self findTabBarController] setNeedsOrientationUpdate:true];
 }
 
 - (void)viewWillAppear:(BOOL)animated

ios/conversion/RNSConversions.mm

@@ -24,7 +24,7 @@ UIInterfaceOrientationMask UIInterfaceOrientationMaskFromRNSOrientation(RNSOrien
       RCTLogError(@"[RNScreens] RNSOrientationInherit does not map directly to any UIInterfaceOrientationMask");
       return 0;
     default:
-      RCTLogError(@"[RNScreens] unsupported orientaion");
+      RCTLogError(@"[RNScreens] Unsupported orientation");
       return 0;
   }
 }
@@ -46,7 +46,7 @@ RNSOrientation RNSOrientationFromUIInterfaceOrientationMask(UIInterfaceOrientati
     case UIInterfaceOrientationMaskPortrait:
       return RNSOrientationPortrait;
     default:
-      RCTLogError(@"[RNScreens] unsupported orientation mask");
+      RCTLogError(@"[RNScreens] Unsupported orientation mask");
       return RNSOrientationInherit;
   }
 }