fix(iOS): Replace calls to UIOffset ctors with calls to UIOffsetMake

Seems that `UIOffset(float, float)` ctor does not exist on tvOS.
I decided to switch to the main factory function.

Author: kkafar

ios/bottom-tabs/RNSBottomTabsHostComponentView.mm

@@ -77,7 +77,7 @@ - (void)resetProps
   _tabBarItemTitleFontWeight = nil;
   _tabBarItemTitleFontStyle = nil;
   _tabBarItemTitleFontColor = nil;
-  _tabBarItemTitlePositionAdjustment = UIOffset(0.0, 0.0);
+  _tabBarItemTitlePositionAdjustment = UIOffsetMake(0.0, 0.0);
 
   _tabBarItemIconColor = nil;
 

ios/bottom-tabs/RNSBottomTabsScreenComponentView.mm

@@ -2,8 +2,8 @@
 #import "NSString+RNSUtility.h"
 #import "RNSConversions.h"
 #import "RNSDefines.h"
-#import "RNSTabBarController.h"
 #import "RNSScrollViewHelper.h"
+#import "RNSTabBarController.h"
 
 #if RCT_NEW_ARCH_ENABLED
 #import <React/RCTConversions.h>
@@ -24,7 +24,7 @@ @implementation RNSBottomTabsScreenComponentView {
   RNSBottomTabsHostComponentView *__weak _Nullable _reactSuperview;
 
   RNSBottomTabsScreenEventEmitter *_Nonnull _reactEventEmitter;
-  
+
   // We need this information to warn users about dynamic changes to behavior being currently unsupported.
   BOOL _isOverrideScrollViewContentInsetAdjustmentBehaviorSet;
 #if !RCT_NEW_ARCH_ENABLED
@@ -72,7 +72,7 @@ - (void)resetProps
   _tabBarItemTitleFontWeight = nil;
   _tabBarItemTitleFontStyle = nil;
   _tabBarItemTitleFontColor = nil;
-  _tabBarItemTitlePositionAdjustment = UIOffset(0.0, 0.0);
+  _tabBarItemTitlePositionAdjustment = UIOffsetMake(0.0, 0.0);
 
   _tabBarItemIconColor = nil;
 
@@ -231,15 +231,17 @@ - (void)updateProps:(const facebook::react::Props::Shared &)props
         newComponentProps.specialEffects.repeatedTabSelection.scrollToTop;
   }
 
-  if (newComponentProps.overrideScrollViewContentInsetAdjustmentBehavior
-      != oldComponentProps.overrideScrollViewContentInsetAdjustmentBehavior) {
-    _overrideScrollViewContentInsetAdjustmentBehavior = newComponentProps.overrideScrollViewContentInsetAdjustmentBehavior;
-    
+  if (newComponentProps.overrideScrollViewContentInsetAdjustmentBehavior !=
+      oldComponentProps.overrideScrollViewContentInsetAdjustmentBehavior) {
+    _overrideScrollViewContentInsetAdjustmentBehavior =
+        newComponentProps.overrideScrollViewContentInsetAdjustmentBehavior;
+
     if (_isOverrideScrollViewContentInsetAdjustmentBehaviorSet) {
-      RCTLogWarn(@"[RNScreens] changing overrideScrollViewContentInsetAdjustmentBehavior dynamically is currently unsupported");
+      RCTLogWarn(
+          @"[RNScreens] changing overrideScrollViewContentInsetAdjustmentBehavior dynamically is currently unsupported");
     }
   }
-  
+
   // This flag is set to YES when overrideScrollViewContentInsetAdjustmentBehavior prop
   // is assigned for the first time. This allows us to identify any subsequent changes to this prop,
   // enabling us to warn users that dynamic changes are not supported.

ios/conversion/RNSConversions-BottomTabs.mm

@@ -83,7 +83,7 @@
 UIOffset RNSBottomTabsTabBarItemTitlePositionAdjustmentStruct(
     react::RNSBottomTabsTabBarItemTitlePositionAdjustmentStruct titlePositionAdjustment)
 {
-  return UIOffset(titlePositionAdjustment.horizontal, titlePositionAdjustment.vertical);
+  return UIOffsetMake(titlePositionAdjustment.horizontal, titlePositionAdjustment.vertical);
 }
 
 std::optional<UIBlurEffectStyle> RNSMaybeUIBlurEffectStyleFromRNSBottomTabsScreenTabBarBlurEffect(
@@ -169,7 +169,7 @@ UIOffset RNSBottomTabsTabBarItemTitlePositionAdjustmentStruct(
 UIOffset RNSBottomTabsScreenTabBarItemTitlePositionAdjustmentStruct(
     react::RNSBottomTabsScreenTabBarItemTitlePositionAdjustmentStruct titlePositionAdjustment)
 {
-  return UIOffset(titlePositionAdjustment.horizontal, titlePositionAdjustment.vertical);
+  return UIOffsetMake(titlePositionAdjustment.horizontal, titlePositionAdjustment.vertical);
 }
 
 }; // namespace rnscreens::conversion