Add Interest During Construction (IDC) capital cost output

softwareengineerprogrammer · softwareengineerprogrammer · commit 00e1b5e15403 · 2025-11-24T10:05:27.000-08:00
diff --git a/src/geophires_x/Economics.py b/src/geophires_x/Economics.py
@@ -2223,10 +2223,7 @@ def __init__(self, model: Model):
             PreferredUnits=PercentUnit.PERCENT,
             CurrentUnits=PercentUnit.PERCENT,
             ToolTipText='The accrued inflation on total capital costs over the construction period, '
-                        f'as defined by {self.inflrateconstruction.Name}. '
-                        'For SAM Economic Models, this is calculated automatically by compounding '
-                        f'{self.RINFL.Name} over Construction Years '
-                        f'if {self.inflrateconstruction.Name} is not provided.'
+                        f'as defined by {self.inflrateconstruction.Name}.'
         )
 
         self.inflation_cost_during_construction = self.OutputParameterDict[
diff --git a/src/geophires_x/EconomicsUtils.py b/src/geophires_x/EconomicsUtils.py
@@ -153,7 +153,9 @@ def interest_during_construction_output_parameter() -> OutputParameter:
         UnitType=Units.CURRENCY,
         PreferredUnits=CurrencyUnit.MDOLLARS,
         CurrentUnits=CurrencyUnit.MDOLLARS,
-        ToolTipText='The sum of interest paid during construction.',  # WIP/TODO
+        ToolTipText='The total accumulated interest incurred on debt during the construction phase. '
+        'This cost is capitalized (added to the loan principal and total installed cost) '
+        'rather than paid in cash.',
     )
 
 
@@ -193,8 +195,6 @@ class PreRevenueCostsAndCashflow:
     inflation_cost_usd: float = 0.0
 
     pre_revenue_cash_flow_profile: list[list[float | str]] = field(default_factory=list)
-    # pre_revenue_cash_flow_profile_dict: dict[str, list[float]] = field(default_factory=dict)
-    # """Maps SAM's row names (str) to a list of pre-revenue values"""
 
     @property
     def effective_debt_percent(self) -> float:
diff --git a/src/geophires_x/Outputs.py b/src/geophires_x/Outputs.py
@@ -274,9 +274,10 @@ def PrintOutputs(self, model: Model):
                         label = Outputs._field_label(field.Name, 49)
                         f.write(f'      {label}{field.value:10.2f} {field.CurrentUnits.value}\n')
 
-                acf: OutputParameter = econ.accrued_financing_during_construction_percentage
-                acf_label = Outputs._field_label(acf.display_name, 49)
-                f.write(f'      {acf_label}{acf.value:10.2f} {acf.CurrentUnits.value}\n')
+                if not is_sam_econ_model:  # (parameter is ambiguous to the point of meaninglessness for SAM-EM)
+                    acf: OutputParameter = econ.accrued_financing_during_construction_percentage
+                    acf_label = Outputs._field_label(acf.display_name, 49)
+                    f.write(f'      {acf_label}{acf.value:10.2f} {acf.CurrentUnits.value}\n')
 
                 display_inflation_costs_in_economic_parameters: bool = (
                     econ.econmodel.value in [EconomicModel.BICYCLE,
diff --git a/src/geophires_x_schema_generator/geophires-result.json b/src/geophires_x_schema_generator/geophires-result.json
@@ -101,7 +101,7 @@
         },
         "Accrued financing during construction": {
           "type": "number",
-          "description": "The accrued inflation on total capital costs over the construction period, as defined by Inflation Rate During Construction. For SAM Economic Models, this is calculated automatically by compounding Inflation Rate over Construction Years if Inflation Rate During Construction is not provided.",
+          "description": "The accrued inflation on total capital costs over the construction period, as defined by Inflation Rate During Construction.",
           "units": "%"
         },
         "Inflation costs during construction": {
@@ -447,6 +447,11 @@
           "description": "The calculated amount of cost escalation due to inflation over the construction period.",
           "units": "MUSD"
         },
+        "Interest during construction (IDC)": {
+          "type": "number",
+          "description": "The total accumulated interest incurred on debt during the construction phase. This cost is capitalized (added to the loan principal and total installed cost) rather than paid in cash.",
+          "units": "MUSD"
+        },
         "Total Add-on CAPEX": {
           "type": "number",
           "description": "AddOn CAPEX Total",
diff --git a/tests/examples/Fervo_Project_Cape-4.out b/tests/examples/Fervo_Project_Cape-4.out
@@ -6,8 +6,8 @@ Simulation Metadata
 ----------------------
  GEOPHIRES Version: 3.10.10
  Simulation Date: 2025-11-24
- Simulation Time:  09:38
- Calculation Time:      1.727 sec
+ Simulation Time:  09:47
+ Calculation Time:      1.731 sec
 
                            ***SUMMARY OF RESULTS***
 
@@ -28,7 +28,6 @@ Simulation Metadata
       Real Discount Rate:                                   12.00 %
       Nominal Discount Rate:                                14.58 %
       WACC:                                                  8.30 %
-      Accrued financing during construction:                 0.00 %
       Project lifetime:                                      30 yr
       Capacity factor:                                       90.0 %
       Project NPV:                                         483.35 MUSD
diff --git a/tests/examples/example_SAM-single-owner-PPA-2.out b/tests/examples/example_SAM-single-owner-PPA-2.out
@@ -6,8 +6,8 @@ Simulation Metadata
 ----------------------
  GEOPHIRES Version: 3.10.10
  Simulation Date: 2025-11-24
- Simulation Time:  09:38
- Calculation Time:      0.983 sec
+ Simulation Time:  09:47
+ Calculation Time:      0.970 sec
 
                            ***SUMMARY OF RESULTS***
 
@@ -28,7 +28,6 @@ Simulation Metadata
       Real Discount Rate:                                    7.00 %
       Nominal Discount Rate:                                 9.14 %
       WACC:                                                  6.41 %
-      Accrued financing during construction:                 0.00 %
       Project lifetime:                                      20 yr
       Capacity factor:                                       90.0 %
       Project NPV:                                        2877.00 MUSD
diff --git a/tests/examples/example_SAM-single-owner-PPA-3.out b/tests/examples/example_SAM-single-owner-PPA-3.out
@@ -6,8 +6,8 @@ Simulation Metadata
 ----------------------
  GEOPHIRES Version: 3.10.10
  Simulation Date: 2025-11-24
- Simulation Time:  09:38
- Calculation Time:      1.156 sec
+ Simulation Time:  09:47
+ Calculation Time:      1.172 sec
 
                            ***SUMMARY OF RESULTS***
 
@@ -28,7 +28,6 @@ Simulation Metadata
       Real Discount Rate:                                    8.00 %
       Nominal Discount Rate:                                10.16 %
       WACC:                                                  7.57 %
-      Accrued financing during construction:                 0.00 %
       Project lifetime:                                      20 yr
       Capacity factor:                                       90.0 %
       Project NPV:                                         210.63 MUSD
diff --git a/tests/examples/example_SAM-single-owner-PPA-4.out b/tests/examples/example_SAM-single-owner-PPA-4.out
@@ -6,8 +6,8 @@ Simulation Metadata
 ----------------------
  GEOPHIRES Version: 3.10.10
  Simulation Date: 2025-11-24
- Simulation Time:  09:38
- Calculation Time:      1.161 sec
+ Simulation Time:  09:47
+ Calculation Time:      1.162 sec
 
                            ***SUMMARY OF RESULTS***
 
@@ -28,7 +28,6 @@ Simulation Metadata
       Real Discount Rate:                                    8.00 %
       Nominal Discount Rate:                                10.16 %
       WACC:                                                  7.57 %
-      Accrued financing during construction:                 0.00 %
       Project lifetime:                                      20 yr
       Capacity factor:                                       90.0 %
       Project NPV:                                         103.00 MUSD
diff --git a/tests/examples/example_SAM-single-owner-PPA-5.out b/tests/examples/example_SAM-single-owner-PPA-5.out
@@ -6,8 +6,8 @@ Simulation Metadata
 ----------------------
  GEOPHIRES Version: 3.10.10
  Simulation Date: 2025-11-24
- Simulation Time:  09:38
- Calculation Time:      1.754 sec
+ Simulation Time:  09:47
+ Calculation Time:      1.722 sec
 
                            ***SUMMARY OF RESULTS***
 
@@ -28,7 +28,6 @@ Simulation Metadata
       Real Discount Rate:                                    8.00 %
       Nominal Discount Rate:                                10.48 %
       WACC:                                                  7.60 %
-      Accrued financing during construction:                 3.15 %
       Project lifetime:                                      30 yr
       Capacity factor:                                       90.0 %
       Project NPV:                                          91.53 MUSD
diff --git a/tests/examples/example_SAM-single-owner-PPA.out b/tests/examples/example_SAM-single-owner-PPA.out
@@ -6,8 +6,8 @@ Simulation Metadata
 ----------------------
  GEOPHIRES Version: 3.10.10
  Simulation Date: 2025-11-24
- Simulation Time:  09:38
- Calculation Time:      1.164 sec
+ Simulation Time:  09:47
+ Calculation Time:      1.165 sec
 
                            ***SUMMARY OF RESULTS***
 
@@ -28,7 +28,6 @@ Simulation Metadata
       Real Discount Rate:                                    8.00 %
       Nominal Discount Rate:                                10.16 %
       WACC:                                                  7.57 %
-      Accrued financing during construction:                 0.00 %
       Project lifetime:                                      20 yr
       Capacity factor:                                       90.0 %
       Project NPV:                                         126.12 MUSD
diff --git a/tests/geophires_x_tests/test_economics_sam.py b/tests/geophires_x_tests/test_economics_sam.py
@@ -377,6 +377,29 @@ def test_inflation_rate_during_construction(self):
 
         self.assertAlmostEqual(tic_no_infl * (1 + infl_rate), tic_infl, places=0)
 
+        # TODO/WIP enable when multiple construction years are supported https://github.com/NREL/GEOPHIRES-X/issues/406
+        # def _infl_cost_musd(r: GeophiresXResult) -> float:
+        #     return r.result['CAPITAL COSTS (M$)']['Inflation costs during construction']['value']
+        # params3 = {
+        #     'Construction Years': 3,
+        #     'Inflation Rate': 0.04769,
+        # }
+        # r3: GeophiresXResult = self._get_result(
+        #     params3,
+        #     file_path=self._get_test_file_path('generic-egs-case-3_no-inflation-rate-during-construction.txt')
+        # )
+        # self.assertEqual(15.0, _accrued_financing(r3))
+        #
+        # params4 = {
+        #     'Construction Years': 3,
+        #     'Inflation Rate During Construction': 0.15,
+        # }
+        # r4: GeophiresXResult = self._get_result(
+        #     params4,
+        #     file_path=self._get_test_file_path('generic-egs-case-3_no-inflation-rate-during-construction.txt')
+        # )
+        # self.assertEqual(15.0, _accrued_financing(r4))
+
     def test_ptc(self):
         def assert_ptc(params, expected_ptc_usd_per_kWh):
             m: Model = EconomicsSamTestCase._new_model(self._egs_test_file_path(), additional_params=params)
@@ -627,7 +650,12 @@ def _payback_period(_r: GeophiresXResult) -> float:
 
     def test_accrued_financing_during_construction(self):
         def _accrued_financing(_r: GeophiresXResult) -> float:
-            return _r.result['ECONOMIC PARAMETERS']['Accrued financing during construction']['value']
+            econ_params = _r.result['ECONOMIC PARAMETERS']
+            acf_key = 'Accrued financing during construction'
+            if econ_params[acf_key] is None:
+                self.skipTest(f'Economic parameters do not contain {acf_key}. (This is expected/OK.)')
+
+            return econ_params[acf_key]['value']
 
         params1 = {
             'Construction Years': 1,
@@ -647,27 +675,6 @@ def _accrued_financing(_r: GeophiresXResult) -> float:
         )
         self.assertEqual(0, _accrued_financing(r2))
 
-        # TODO enable when multiple construction years are supported https://github.com/NREL/GEOPHIRES-X/issues/406
-        # params3 = {
-        #     'Construction Years': 3,
-        #     'Inflation Rate': 0.04769,
-        # }
-        # r3: GeophiresXResult = self._get_result(
-        #     params3,
-        #     file_path=self._get_test_file_path('generic-egs-case-3_no-inflation-rate-during-construction.txt')
-        # )
-        # self.assertEqual(15.0, _accrued_financing(r3))
-        #
-        # params4 = {
-        #     'Construction Years': 3,
-        #     'Inflation Rate During Construction': 0.15,
-        # }
-        # r4: GeophiresXResult = self._get_result(
-        #     params4,
-        #     file_path=self._get_test_file_path('generic-egs-case-3_no-inflation-rate-during-construction.txt')
-        # )
-        # self.assertEqual(15.0, _accrued_financing(r4))
-
     def test_add_ons(self):
         no_add_ons_result = self._get_result(
             {'Do AddOn Calculations': False}, file_path=self._get_test_file_path('egs-sam-em-add-ons.txt')
