Workaround for float('nan') != float('nan')

Author: softwareengineerprogrammer

src/geophires_x_client/geophires_x_result.py

@@ -862,8 +862,8 @@ def _parse_number(self, number_str, field='string') -> int | float:
             return None
 
         try:
-            number_str = number_str.replace(',', '')
-            if '.' in number_str or number_str.lower() == 'nan':
+            number_str = number_str.replace(',', '').lower()
+            if '.' in number_str or number_str == 'nan':
                 # TODO should probably ideally use decimal.Decimal to preserve precision,
                 #  i.e. 1.00 for USD instead of 1.0
                 return float(number_str)

tests/test_geophires_x.py

@@ -1,3 +1,4 @@
+import math
 import os
 import tempfile
 import uuid
@@ -194,6 +195,22 @@ def get_output_file_for_example(example_file: str):
                 del expected_result.result['metadata']
                 del expected_result.result['Simulation Metadata']
 
+                def sanitize_nan(r: GeophiresXResult) -> None:
+                    """
+                    Workaround for float('nan') != float('nan')
+                    See https://stackoverflow.com/questions/51728427/unittest-how-to-assert-if-the-two-possibly-nan-values-are-equal
+
+                    TODO generalize beyond Project IRR
+                    """
+                    try:
+                        if math.isnan(r.result['ECONOMIC PARAMETERS']['Project IRR']['value']):
+                            r.result['ECONOMIC PARAMETERS']['Project IRR']['value'] = 'NaN'
+                    except TypeError:
+                        pass
+
+                sanitize_nan(geophires_result)
+                sanitize_nan(expected_result)
+
                 try:
                     self.assertDictEqual(
                         expected_result.result, geophires_result.result, msg=f'Example test: {example_file_path}'