Skip to content

Commit 5f62dab

Browse files
treat output vals of both int and float as number
1 parent 93cd08b commit 5f62dab

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/geophires_x/Parameter.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ def __post_init__(self):
102102
self.json_parameter_type = _JSON_PARAMETER_TYPE_STRING
103103
elif isinstance(self.value, bool):
104104
self.json_parameter_type = _JSON_PARAMETER_TYPE_BOOLEAN
105-
elif isinstance(self.value, int):
106-
self.json_parameter_type = _JSON_PARAMETER_TYPE_INTEGER
107-
elif isinstance(self.value, float):
105+
elif isinstance(self.value, float) or isinstance(self.value, int):
106+
# Default number values may not be representative of whether calculated values are integer-only,
107+
# so we specify number type even if value is int.
108108
self.json_parameter_type = _JSON_PARAMETER_TYPE_NUMBER
109109
elif isinstance(self.value, dict):
110110
self.json_parameter_type = _JSON_PARAMETER_TYPE_OBJECT

tests/test_parameter.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,8 @@ def test_output_parameter_with_preferred_units(self):
154154
def test_output_parameter_json_types(self):
155155
cases = [
156156
('foo', 'string'),
157-
(1, 'integer'),
157+
(1, 'number'),
158+
(44.4, 'number'),
158159
(True, 'boolean'),
159160
([1, 2, 3], 'array'),
160161
({4, 5, 6}, 'array'),

0 commit comments

Comments
 (0)