Output reservoir impedance with appropriate decimal places for its allowed values

Author: softwareengineerprogrammer

src/geophires_x/Outputs.py

@@ -1743,7 +1743,7 @@ def PrintOutputs(self, model: Model):
                         f.write(f'      Fracture separation:                              {model.reserv.fracsepcalc.value:10.2f} ' + model.reserv.fracsep.CurrentUnits.value + NL)
                     f.write(f'      Reservoir volume:                              {model.reserv.resvolcalc.value:10.0f} ' + model.reserv.resvol.CurrentUnits.value + NL)
                     if model.wellbores.impedancemodelused.value:
-                        f.write(f'      Reservoir impedance:                              {model.wellbores.impedance.value/1000:10.2f} ' + model.wellbores.impedance.CurrentUnits.value + NL)
+                        f.write(f'      Reservoir impedance:                              {model.wellbores.impedance.value/1000:10.4f} {model.wellbores.impedance.CurrentUnits.value}\n')
                     else:
                         if model.wellbores.overpressure_percentage.Provided:
                             # write the reservoir pressure as an average in the overpressure case

src/geophires_x/WellBores.py

@@ -796,7 +796,11 @@ def __init__(self, model: Model):
         )
         self.impedance = self.ParameterDict[self.impedance.Name] = floatParameter(
             "Reservoir Impedance",
+
+            # Note default/input value units are converted as a special case in read_parameters; see
+            # https://github.com/NREL/GEOPHIRES-X/blob/d51eb8d1dc8b21c7a79c4d35f296d740347658e0/src/geophires_x/WellBores.py#L1280-L1282
             DefaultValue=1000.0,
+
             Min=1E-4,
             Max=1E4,
             UnitType=Units.IMPEDANCE,
@@ -1277,7 +1281,8 @@ def read_parameters(self, model: Model) -> None:
                     # impedance: impedance per well pair (input as GPa*s/m^3 and converted to KPa/kg/s
                     # (assuming 1000 for density; density will be corrected for later))
                     elif ParameterToModify.Name == "Reservoir Impedance":
-                        # shift it by a constant to make the units right, per line 619 of GEOPHIRES 2
+                        # shift it by a constant to make the units right, per line 619 of GEOPHIRES 2:
+                        # https://github.com/NREL/GEOPHIRES-v2/blob/08485b98ae02aeb7a5acd972f906b2ea81ae2647/GEOPHIRESv2.py#L610-L619
                         self.impedance.value = self.impedance.value * (1E6 / 1E3)
                         self.impedancemodelused.value = True
                         if self.impedance.Provided is False:

tests/examples/Fervo_Project_Cape-3.out

@@ -4,10 +4,10 @@
 
 Simulation Metadata
 ----------------------
- GEOPHIRES Version: 3.7.1
- Simulation Date: 2025-01-22
- Simulation Time:  10:48
- Calculation Time:      0.889 sec
+ GEOPHIRES Version: 3.7.12
+ Simulation Date: 2025-02-17
+ Simulation Time:  10:42
+ Calculation Time:      0.890 sec
 
                            ***SUMMARY OF RESULTS***
 
@@ -70,7 +70,7 @@ Simulation Metadata
       Number of fractures:                                  149.00
       Fracture separation:                                   30.00 meter
       Reservoir volume:                              88800000000 m**3
-      Reservoir impedance:                                    0.00 GPa.s/m**3
+      Reservoir impedance:                                  0.0010 GPa.s/m**3
       Reservoir density:                                   2800.00 kg/m**3
       Reservoir thermal conductivity:                         3.05 W/m/K
       Reservoir heat capacity:                              790.00 J/kg/K