workaround pint's apparent inability to handle '%' as a unit in python3.8

softwareengineerprogrammer · softwareengineerprogrammer · commit 7f1fc0a0f2fc · 2024-10-11T09:35:24.000-07:00
diff --git a/src/geophires_x/Economics.py b/src/geophires_x/Economics.py
@@ -1383,7 +1383,7 @@ def __init__(self, model: Model):
         )
 
         fir_default_unit = PercentUnit.PERCENT
-        fir_default_val = self.discountrate.quantity().to(fir_default_unit.value).magnitude
+        fir_default_val = self.discountrate.quantity().to('percent').magnitude  # pint can't handle '%' in python 3.8
         self.FixedInternalRate = self.ParameterDict[self.FixedInternalRate.Name] = floatParameter(
             "Fixed Internal Rate",
             DefaultValue=fir_default_val,

Original file line number	Diff line number	Diff line change
`@@ -1383,7 +1383,7 @@ def __init__(self, model: Model):`
`1383`	`1383`	`)`
`1384`	`1384`
`1385`	`1385`	`fir_default_unit = PercentUnit.PERCENT`
`1386`		`- fir_default_val = self.discountrate.quantity().to(fir_default_unit.value).magnitude`
	`1386`	`+ fir_default_val = self.discountrate.quantity().to('percent').magnitude # pint can't handle '%' in python 3.8`
`1387`	`1387`	`self.FixedInternalRate = self.ParameterDict[self.FixedInternalRate.Name] = floatParameter(`
`1388`	`1388`	`"Fixed Internal Rate",`
`1389`	`1389`	`DefaultValue=fir_default_val,`