Skip to content

Commit 8f2eda9

Browse files
use float parameter instead of int parametr min max limitations for SBT object
1 parent 8419423 commit 8f2eda9

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/geophires_x/SBTReservoir.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -248,18 +248,20 @@ def __init__(self, model: Model):
248248
ErrMessage='assume default for Initial Timestep Count (5)',
249249
ToolTipText='The number of timesteps in the first ~3 hours of model'
250250
)
251-
self.final_timestep_count = self.ParameterDict[self.final_timestep_count.Name] = intParameter(
251+
self.final_timestep_count = self.ParameterDict[self.final_timestep_count.Name] = floatParameter(
252252
'SBT Final Timestep Count',
253253
DefaultValue=70,
254-
AllowableRange = [5, 1000],
254+
Min=5,
255+
Max=1000,
255256
UnitType=Units.NONE,
256257
ErrMessage='assume default for Final Timestep Count 70)',
257258
ToolTipText='The number of timesteps after the first ~3 hours of model'
258259
)
259-
self.initial_final_timestep_transition = self.ParameterDict[self.initial_final_timestep_transition.Name] = intParameter(
260+
self.initial_final_timestep_transition = self.ParameterDict[self.initial_final_timestep_transition.Name] = floatParameter(
260261
'SBT Initial to Final Timestep Transition',
261262
DefaultValue=9900,
262-
AllowableRange = [1, 40_000_000],
263+
Min=1,
264+
Max=40_000_000,
263265
UnitType=Units.TIME,
264266
PreferredUnits=TimeUnit.SECOND,
265267
CurrentUnits=TimeUnit.SECOND,
@@ -1098,7 +1100,7 @@ def Calculate_Uloop(self, model):
10981100
initial_times = np.linspace(0, self.initial_final_timestep_transition.value, self.initial_timestep_count.value)
10991101
initial_time_interval = initial_times[1] - initial_times[0]
11001102
final_start = self.initial_final_timestep_transition.value + initial_time_interval
1101-
final_times = np.logspace(np.log10(final_start), np.log10(model.surfaceplant.plant_lifetime.value * 365 * 24 * 3600), self.final_timestep_count.value)
1103+
final_times = np.logspace(np.log10(final_start), np.log10(model.surfaceplant.plant_lifetime.value * 365 * 24 * 3600), int(self.final_timestep_count.value))
11021104
times = np.concatenate([initial_times, final_times])
11031105
# Note 1: When providing a variable injection temperature or flow rate, a finer time grid should be considered.
11041106
# Below is one with long term time steps of about 36 days.

0 commit comments

Comments
 (0)