Skip to content

Commit 93d9479

Browse files
Clarify status of hashing/caching
1 parent 70483b8 commit 93d9479

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

tests/test_geophires_x.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,10 @@ def test_geophires_x_end_use_direct_use_heat(self):
5858
del result_same_input.result['metadata']
5959
self.assertDictEqual(result.result, result_same_input.result)
6060

61-
# assert result == result_same_input # TODO assert that result was retrieved from cache instead of recomputed (somehow)
61+
# See TODO in geophires_x_client.geophires_input_parameters.GeophiresInputParameters.__hash__ - if/when hashes
62+
# of equivalent sets of parameters are made equal, the commented assertion below will test that caching is
63+
# working as expected.
64+
# assert result == result_same_input
6265

6366
def test_geophires_x_end_use_electricity(self):
6467
client = GeophiresXClient()

tests/test_geophires_x_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,10 @@ def test_ccus_profile(self):
389389
ccus_profile,
390390
)
391391

392-
@unittest.skip('Not currently relevant')
392+
@unittest.skip(
393+
'Not currently relevant - '
394+
'see TODO in geophires_x_client.geophires_input_parameters.GeophiresInputParameters.__hash__'
395+
)
393396
def test_input_hashing(self):
394397
input1 = GeophiresInputParameters(
395398
{'End-Use Option': EndUseOption.DIRECT_USE_HEAT.value, 'Gradient 1': 50, 'Maximum Temperature': 250}

0 commit comments

Comments
 (0)