fix incorrect parameter dict declaration

Author: softwareengineerprogrammer

src/geophires_x/Economics.py

@@ -876,10 +876,10 @@ def __init__(self, model: Model):
         )
 
         # TODO add support for float values
-        self.cashflow_series_start_year = self.ParameterDict[self.discountrate.Name] = intParameter(
+        self.cashflow_series_start_year = self.ParameterDict[self.cashflow_series_start_year.Name] = intParameter(
             "Cashflow Series Start Year",
             DefaultValue=0,
-            AllowableRange=[0,1],
+            AllowableRange=[0, 1],
             UnitType=Units.NONE,
             ErrMessage=f'assume default Cashflow Series Start Year ({0})',
             ToolTipText="Cashflow Series Start Year used to calculate NPV"

tests/test_geophires_x.py

@@ -566,19 +566,19 @@ def assertHasLogRecordWithMessage(logs_, message):
         with self.assertLogs(level='INFO') as logs:
             result = client.get_geophires_result(input_params(discount_rate='0.042'))
 
-            assert result is not None
-            assert result.result['ECONOMIC PARAMETERS']['Interest Rate']['value'] == 4.2
-            assert result.result['ECONOMIC PARAMETERS']['Interest Rate']['unit'] == '%'
+            self.assertIsNotNone(result)
+            self.assertEqual(4.2, result.result['ECONOMIC PARAMETERS']['Interest Rate']['value'])
+            self.assertEqual('%', result.result['ECONOMIC PARAMETERS']['Interest Rate']['unit'])
             assertHasLogRecordWithMessage(
                 logs, 'Set Fixed Internal Rate to 4.2 percent because Discount Rate was provided (0.042)'
             )
 
         with self.assertLogs(level='INFO') as logs2:
             result2 = client.get_geophires_result(input_params(fixed_internal_rate='4.2'))
 
-            assert result2 is not None
-            assert result2.result['ECONOMIC PARAMETERS']['Interest Rate']['value'] == 4.2
-            assert result2.result['ECONOMIC PARAMETERS']['Interest Rate']['unit'] == '%'
+            self.assertIsNotNone(result2)
+            self.assertEqual(4.2, result2.result['ECONOMIC PARAMETERS']['Interest Rate']['value'])
+            self.assertEqual('%', result2.result['ECONOMIC PARAMETERS']['Interest Rate']['unit'])
 
             assertHasLogRecordWithMessage(
                 logs2, 'Set Discount Rate to 0.042 because Fixed Internal Rate was provided (4.2 percent)'