Merge pull request NREL#227 from kfbeckers/main

fixes vapor pressure error above critical temperature NREL#214

Author: softwareengineerprogrammer

src/geophires_x/WellBores.py

@@ -436,7 +436,10 @@ def ProdPressureDropAndPumpingPowerUsingIndexes(
         Pexcess_kPa = 344.7  # = 50 psi
 
         # Minimum production pump inlet pressure and minimum wellhead pressure
-        Pminimum_kPa = vapor_pressure_water_kPa(Trock_degC) + Pexcess_kPa
+        if Trock_degC < 373.9:
+            Pminimum_kPa = vapor_pressure_water_kPa(Trock_degC) + Pexcess_kPa
+        else: #above the critical water temperature, vapor no longer occurs and vapor pressure can no longer be calculated. A "dummy" vapor pressure can be assumed as the fluid phase no longer impacts the pump depth.
+            Pminimum_kPa = 100 #setting artificially to 1 bar = 100 kPa
 
         if usebuiltinppwellheadcorrelation:
             Pprodwellhead = Pminimum_kPa  # production wellhead pressure [kPa]
@@ -557,8 +560,10 @@ def InjPressureDropAndPumpingPowerUsingIndexes(
         Pexcess_kPa = 344.7 # = 50 psi
 
         # Minimum production pump inlet pressure and minimum wellhead pressure
-        Pminimum_kPa = vapor_pressure_water_kPa(Trock_degC) + Pexcess_kPa
-
+        if Trock_degC < 373.9:
+            Pminimum_kPa = vapor_pressure_water_kPa(Trock_degC) + Pexcess_kPa
+        else: #above the critical water temperature, vapor no longer occurs and vapor pressure can no longer be calculated. A "dummy" vapor pressure can be assumed as the fluid phase no longer impacts the pump depth.
+            Pminimum_kPa = 100 #setting artificially to 1 bar = 100 kPa
         if usebuiltinppwellheadcorrelation:
             Pprodwellhead = Pminimum_kPa  # production wellhead pressure [kPa]
         else:

tests/test_geophires_x.py

@@ -345,3 +345,22 @@ def get_fcr_lcoe(fcr: float) -> float:
         self.assertAlmostEqual(9.61, get_fcr_lcoe(0.05), places=1)
         self.assertAlmostEqual(3.33, get_fcr_lcoe(0.0001), places=1)
         self.assertAlmostEqual(104.34, get_fcr_lcoe(0.8), places=0)
+
+    def test_vapor_pressure_above_critical_temperature(self):
+        """https://github.com/NREL/GEOPHIRES-X/issues/214"""
+
+        input_params = GeophiresInputParameters(
+            {
+                'End-Use Option': 2,
+                'Reservoir Depth': 6,
+                'Gradient 1': 75,
+                'Reservoir Model': 1,
+                'Time steps per year': 1,
+                'Maximum Temperature': 500,
+                'Print Output to Console': 0,
+            }
+        )
+
+        result = GeophiresXClient().get_geophires_result(input_params)
+        self.assertIsNotNone(result)
+        self.assertIn('SUMMARY OF RESULTS', result.result)