tweak unit tests and error message as requested for PR 367

Author: jeffbourdier

src/geophires_x/SurfacePlant.py

@@ -153,8 +153,8 @@ def electricity_heat_production(self, enduse_option: EndUseOptions, availability
         # next do the electricity produced - the same for all, except enduse=5, where it is recalculated
         ElectricityProduced = availability * etau * nprod * prodwellflowrate
         if ElectricityProduced.max() < 0:
-            raise RuntimeError('Electricity production calculated as negative.  '
-                               'Check maximum temperature for power plant type.')
+            # TODO: make message more informative (possibly by hinting that maximum temperature may be too high)
+            raise RuntimeError('Electricity production calculated as negative.')
 
         if enduse_option == EndUseOptions.ELECTRICITY:
             # pure electricity

tests/test_geophires_x.py

@@ -855,7 +855,7 @@ def test_field_gathering_cost(self):
 
         self.assertEqual(fg_cost, result.result['CAPITAL COSTS (M$)']['Field gathering system costs']['value'])
 
-    def test_temperature_limitations(self):
+    def test_ags_temperature_limitations(self):
         client = GeophiresXClient()
 
         with self.assertRaises(RuntimeError) as e:
@@ -864,6 +864,8 @@ def test_temperature_limitations(self):
                     'Is AGS': True,
                     'Well Geometry Configuration': 1,
                     'Injection Temperature': 60,
+                    'Gradient 1': 60,
+                    'Reservoir Depth': 8,
                     'Cylindrical Reservoir Input Depth': 8,
                     'Economic Model': 3,
                 }
@@ -877,14 +879,24 @@ def test_temperature_limitations(self):
                     'Is AGS': True,
                     'Closed-loop Configuration': 2,
                     'Gradient 1': 25,
+                    'Reservoir Depth': 3,
                     'Injection Temperature': 60,
                     'Economic Model': 4,
                 }
             )
             client.get_geophires_result(params)
         self.assertIn('failed to validate CLGS input value', str(e.exception))
 
+    def test_negative_electricity_production_raises_error(self):
+        client = GeophiresXClient()
         with self.assertRaises(RuntimeError) as e:
-            params = GeophiresInputParameters({'Power Plant Type': 2, 'Maximum Temperature': 600})
+            params = GeophiresInputParameters(
+                {
+                    'Reservoir Depth': 5,
+                    'Gradient 1': 112,
+                    'Power Plant Type': 2,
+                    'Maximum Temperature': 600,
+                }
+            )
             client.get_geophires_result(params)
-        self.assertIn('Check maximum temperature for power plant type', str(e.exception))
+        self.assertIn('Electricity production calculated as negative', str(e.exception))