Skip to content

Commit dea6ddf

Browse files
softwareengineerprogrammersoftwareengineerprogrammer
committed
Fix missing percent unit for Water loss rate output
1 parent 7681bcd commit dea6ddf

30 files changed

+85
-83
lines changed

‎src/geophires_x/Outputs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ def PrintOutputs(self, model: Model):
306306
f.write(f' Number of Production Wells: {model.wellbores.nprod.value:10.0f}' + NL)
307307
f.write(f' Number of Injection Wells: {model.wellbores.ninj.value:10.0f}' + NL)
308308
f.write(f' {Outputs._field_label(Outputs.VERTICAL_WELL_DEPTH_OUTPUT_NAME, 49)}{model.reserv.depth.value:10.1f} ' + model.reserv.depth.CurrentUnits.value + NL)
309-
f.write(f' Water loss rate: {model.reserv.waterloss.value*100:10.1f} ' + model.reserv.waterloss.CurrentUnits.value + NL)
309+
f.write(f' Water loss rate: {model.reserv.waterloss.value:10.2f} {model.reserv.waterloss.CurrentUnits.value}\n')
310310
f.write(f' Pump efficiency: {model.surfaceplant.pump_efficiency.value:10.1f} ' + model.surfaceplant.pump_efficiency.CurrentUnits.value + NL)
311311
f.write(f' Injection temperature: {model.wellbores.Tinj.value:10.1f} ' + model.wellbores.Tinj.CurrentUnits.value + NL)
312312
if model.wellbores.rameyoptionprod.value:

‎src/geophires_x/Reservoir.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -320,16 +320,18 @@ def __init__(self, model: Model):
320320
ToolTipText="Geothermal reservoir volume"
321321
)
322322

323+
# noinspection SpellCheckingInspection
323324
self.waterloss = self.ParameterDict[self.waterloss.Name] = floatParameter(
324325
"Water Loss Fraction",
325326
DefaultValue=0.0,
326327
Min=0.0,
327328
Max=0.99,
328329
UnitType=Units.PERCENT,
329-
PreferredUnits=PercentUnit.TENTH,
330330
CurrentUnits=PercentUnit.TENTH,
331+
PreferredUnits=PercentUnit.PERCENT,
331332
ErrMessage="assume default water loss fraction (0)",
332-
ToolTipText="Fraction of water lost in the reservoir defined as (total geofluid lost)/(total geofluid produced)."
333+
ToolTipText="Fraction of water lost in the reservoir defined as "
334+
"(total geofluid lost)/(total geofluid produced)."
333335
)
334336

335337
self.cprock = self.ParameterDict[self.cprock.Name] = floatParameter(

‎tests/example1_addons.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ EXTENDED ECONOMICS,AddOns Payback Period,,0.0,yr
3636
ENGINEERING PARAMETERS,Number of Production Wells,,2,count
3737
ENGINEERING PARAMETERS,Number of Injection Wells,,2,count
3838
ENGINEERING PARAMETERS,Well depth,,3.0,kilometer
39-
ENGINEERING PARAMETERS,Water loss rate,,2.0,
39+
ENGINEERING PARAMETERS,Water loss rate,,2.0,%
4040
ENGINEERING PARAMETERS,Pump efficiency,,80.0,%
4141
ENGINEERING PARAMETERS,Injection temperature,,50.0,degC
4242
ENGINEERING PARAMETERS,Average production well temperature drop,,3.0,degC

‎tests/examples/Fervo_Norbeck_Latimer_2023.out

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ Simulation Metadata
66
----------------------
77
GEOPHIRES Version: 3.9.7
88
Simulation Date: 2025-05-15
9-
Simulation Time: 09:22
10-
Calculation Time: 0.439 sec
9+
Simulation Time: 10:09
10+
Calculation Time: 0.433 sec
1111

1212
***SUMMARY OF RESULTS***
1313

@@ -39,7 +39,7 @@ Simulation Metadata
3939
Number of Production Wells: 1
4040
Number of Injection Wells: 1
4141
Well depth: 2.3 kilometer
42-
Water loss rate: 10.0
42+
Water loss rate: 10.00 %
4343
Pump efficiency: 80.0 %
4444
Injection temperature: 41.0 degC
4545
Production Wellbore heat transmission calculated with Ramey's model

‎tests/examples/Fervo_Project_Cape-2.out

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ Simulation Metadata
66
----------------------
77
GEOPHIRES Version: 3.9.7
88
Simulation Date: 2025-05-15
9-
Simulation Time: 09:22
10-
Calculation Time: 0.653 sec
9+
Simulation Time: 10:09
10+
Calculation Time: 0.648 sec
1111

1212
***SUMMARY OF RESULTS***
1313

@@ -39,7 +39,7 @@ Simulation Metadata
3939
Number of Production Wells: 1
4040
Number of Injection Wells: 2
4141
Well depth: 2.6 kilometer
42-
Water loss rate: 2.0
42+
Water loss rate: 2.00 %
4343
Pump efficiency: 80.0 %
4444
Injection temperature: 56.7 degC
4545
Production Wellbore heat transmission calculated with Ramey's model

‎tests/examples/Fervo_Project_Cape-3.out

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ Simulation Metadata
66
----------------------
77
GEOPHIRES Version: 3.9.7
88
Simulation Date: 2025-05-15
9-
Simulation Time: 09:22
10-
Calculation Time: 0.868 sec
9+
Simulation Time: 10:09
10+
Calculation Time: 0.866 sec
1111

1212
***SUMMARY OF RESULTS***
1313

@@ -39,7 +39,7 @@ Simulation Metadata
3939
Number of Production Wells: 39
4040
Number of Injection Wells: 39
4141
Well depth: 2.6 kilometer
42-
Water loss rate: 5.0
42+
Water loss rate: 5.00 %
4343
Pump efficiency: 80.0 %
4444
Injection temperature: 56.7 degC
4545
Production Wellbore heat transmission calculated with Ramey's model

‎tests/examples/Fervo_Project_Cape.out

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ Simulation Metadata
66
----------------------
77
GEOPHIRES Version: 3.9.7
88
Simulation Date: 2025-05-15
9-
Simulation Time: 09:23
10-
Calculation Time: 0.650 sec
9+
Simulation Time: 10:09
10+
Calculation Time: 0.651 sec
1111

1212
***SUMMARY OF RESULTS***
1313

@@ -39,7 +39,7 @@ Simulation Metadata
3939
Number of Production Wells: 12
4040
Number of Injection Wells: 12
4141
Well depth: 2.6 kilometer
42-
Water loss rate: 2.0
42+
Water loss rate: 2.00 %
4343
Pump efficiency: 80.0 %
4444
Injection temperature: 56.2 degC
4545
Production Wellbore heat transmission calculated with Ramey's model

‎tests/examples/S-DAC-GT.out

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Simulation Metadata
66
----------------------
77
GEOPHIRES Version: 3.9.7
88
Simulation Date: 2025-05-15
9-
Simulation Time: 09:23
9+
Simulation Time: 10:09
1010
Calculation Time: 0.099 sec
1111

1212
***SUMMARY OF RESULTS***
@@ -41,7 +41,7 @@ Simulation Metadata
4141
Number of Production Wells: 3
4242
Number of Injection Wells: 3
4343
Well depth: 3.1 kilometer
44-
Water loss rate: 2.0
44+
Water loss rate: 2.00 %
4545
Pump efficiency: 80.0 %
4646
Injection temperature: 70.0 degC
4747
User-provided production well temperature drop

‎tests/examples/example1.out

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ Simulation Metadata
66
----------------------
77
GEOPHIRES Version: 3.9.7
88
Simulation Date: 2025-05-15
9-
Simulation Time: 09:22
10-
Calculation Time: 0.776 sec
9+
Simulation Time: 10:09
10+
Calculation Time: 0.780 sec
1111

1212
***SUMMARY OF RESULTS***
1313

@@ -40,7 +40,7 @@ Simulation Metadata
4040
Number of Production Wells: 2
4141
Number of Injection Wells: 2
4242
Well depth: 3.0 kilometer
43-
Water loss rate: 2.0
43+
Water loss rate: 2.00 %
4444
Pump efficiency: 80.0 %
4545
Injection temperature: 50.0 degC
4646
Production Wellbore heat transmission calculated with Ramey's model

‎tests/examples/example10_HP.out

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ Simulation Metadata
66
----------------------
77
GEOPHIRES Version: 3.9.7
88
Simulation Date: 2025-05-15
9-
Simulation Time: 09:22
10-
Calculation Time: 0.097 sec
9+
Simulation Time: 10:09
10+
Calculation Time: 0.096 sec
1111

1212
***SUMMARY OF RESULTS***
1313

@@ -40,7 +40,7 @@ Simulation Metadata
4040
Number of Production Wells: 2
4141
Number of Injection Wells: 2
4242
Well depth: 2.1 kilometer
43-
Water loss rate: 2.0
43+
Water loss rate: 2.00 %
4444
Pump efficiency: 80.0 %
4545
Injection temperature: 83.0 degC
4646
User-provided production well temperature drop

0 commit comments

Comments
 (0)