Migrate CreateQueueRaceConditionTest and FifoDeduplicationTests to new test structure

Author: micossow

rest/rest-sqs-testing-amazon-java-sdk/src/test/scala/org/elasticmq/rest/sqs/CreateQueueRaceConditionTest.scala

@@ -39,7 +39,7 @@ trait AmazonJavaSdkNewTestBase
     val queue = testClient.createQueue("testQueue1").toOption.get
     val sendResult =
       testClient.sendMessage(queue, content, messageAttributes = messageAttributes, awsTraceHeader = awsTraceHeader)
-    sendResult shouldBe Right(())
+    sendResult.isRight shouldBe true
     val message = receiveSingleMessageObject(queue, requestedAttributes, requestedSystemAttributes).orNull
 
     // then

rest/rest-sqs-testing-amazon-java-sdk/src/test/scala/org/elasticmq/rest/sqs/FifoDeduplicationTests.scala

@@ -10,6 +10,8 @@ abstract class AmazonJavaSdkNewTestSuite
     with FifoQueueTests
     with DeadLetterQueueTests
     with MessageMoveTaskTests
+    with CreateQueueRaceConditionTests
+    with FifoDeduplicationTests
 
 class AmazonJavaSdkV1TestSuite extends AmazonJavaSdkNewTestSuite with SqsClientServerCommunication
 class AmazonJavaSdkV2TestSuite extends AmazonJavaSdkNewTestSuite with SqsClientServerWithSdkV2Communication

rest/rest-sqs-testing-amazon-java-sdk/src/test/scala/org/elasticmq/rest/sqs/aws/AmazonJavaSdkNewTestBase.scala

@@ -0,0 +1,39 @@
+package org.elasticmq.rest.sqs.aws
+
+import org.elasticmq.rest.sqs.client._
+
+import java.util.concurrent.Executors
+import scala.concurrent.duration.Duration
+import scala.concurrent.{Await, ExecutionContext, ExecutionContextExecutor, Future}
+
+trait CreateQueueRaceConditionTests extends AmazonJavaSdkNewTestBase {
+
+  test("should create one queue and return its address for every request with the same name and metadata") {
+    implicit val ec: ExecutionContextExecutor = ExecutionContext.fromExecutor(Executors.newFixedThreadPool(100))
+
+    val tasks = (0 until 100).map(_ => Future { testClient.createQueue("abc") })
+    val results = Await.result(Future.sequence(tasks), Duration.Inf)
+
+    results should be(Vector.fill(100)(Right("http://localhost:9321/123456789012/abc")))
+  }
+
+  test("should create one queue and return an error for every request with the same name and different metadata") {
+    implicit val ec: ExecutionContextExecutor = ExecutionContext.fromExecutor(Executors.newFixedThreadPool(100))
+
+    val tasks = (0 until 100).map { index =>
+      Future {
+        testClient.createQueue(
+          "abc",
+          Map(VisibilityTimeoutAttributeName -> (10 + index).toString)
+        )
+      }
+    }
+    val results = Await.result(Future.sequence(tasks), Duration.Inf)
+
+    val grouped = results.groupBy(_.isLeft)
+    val rights = grouped.getOrElse(false, Nil)
+    val lefts = grouped.getOrElse(true, Nil)
+    rights.length should be(1)
+    lefts.length should be(99)
+  }
+}