Skip to content

Commit dedb219

Browse files
authored
Change mima config (#364)
1 parent 3c6eb8d commit dedb219

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,6 @@ jobs:
3939
# identify binary incompatibilities (check build.sbt for details)
4040
mima:
4141
uses: softwaremill/github-actions-workflows/.github/workflows/mima.yml@main
42-
# run on 1) push, 2) external PRs, 3) softwaremill-ci PRs
43-
# do not run on internal, non-steward PRs since those will be run by push to branch
44-
if: |
45-
github.event_name == 'push' ||
46-
github.event.pull_request.head.repo.full_name != github.repository ||
47-
github.event.pull_request.user.login == 'softwaremill-ci'
4842
with:
4943
java-version: '21'
5044
java-opts: '-Xms4g -Xmx4g' # SBT_JAVA_OPTS env parameter adapted for JVM

build.sbt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import com.softwaremill.SbtSoftwareMillCommon.commonSmlBuildSettings
22
import com.softwaremill.Publish.{ossPublishSettings, updateDocs}
33
import com.softwaremill.UpdateVersionInDocs
4+
import com.typesafe.tools.mima.core.{MissingClassProblem, ProblemFilters}
45

56
lazy val commonSettings = commonSmlBuildSettings ++ ossPublishSettings ++ Seq(
67
organization := "com.softwaremill.ox",
@@ -29,7 +30,11 @@ val enableMimaSettings = Seq(
2930
println(s"[info] $current is an M or RC version, no previous version to check with MiMa")
3031
Set.empty
3132
}
32-
}
33+
},
34+
mimaBinaryIssueFilters ++= Seq(
35+
// GroupingTimeout is only ever used within the groupWithin method, never exposed externally
36+
ProblemFilters.exclude[MissingClassProblem]("ox.flow.FlowOps$GroupingTimeout$")
37+
)
3338
)
3439

3540
val scalaTest = "org.scalatest" %% "scalatest" % "3.2.19" % Test

0 commit comments

Comments
 (0)