MPT-9677 Add terminate to order validation

Author: bdjilka

ffc/flows/validation.py

@@ -4,7 +4,7 @@
 from mpt_extension_sdk.flows.pipeline import Pipeline
 
 from ffc.flows.error import strip_trace_id
-from ffc.flows.order import OrderContext, is_purchase_order
+from ffc.flows.order import OrderContext, is_purchase_order, is_terminate_order
 from ffc.flows.steps import OrderTypeIsNotSupported
 from ffc.notifications import notify_unhandled_exception_in_teams
 
@@ -25,6 +25,8 @@ def validate_order(client, order):
     try:
         if is_purchase_order(order):
             has_errors, order = validate_purchase_order(client, order)
+        elif is_terminate_order(order):
+            has_errors, order = validate_terminate_order(client, order)
         else:
             has_errors, order = validate_other_orders(client, order)
 
@@ -46,6 +48,10 @@ def validate_purchase_order(client, order):
     return False, order
 
 
+def validate_terminate_order(client, order):
+    return False, order
+
+
 def validate_other_orders(client, order):
     pipeline = Pipeline(
         OrderTypeIsNotSupported(),

tests/ffc/flows/test_validation.py

@@ -5,12 +5,14 @@
     validate_order,
     validate_other_orders,
     validate_purchase_order,
+    validate_terminate_order,
 )
 
 
-def test_validate_purchase(
+def test_validate_supported_order(
     mpt_client,
     processing_purchase_order,
+    processing_termination_order,
 ):
     has_errors, order = validate_purchase_order(
         mpt_client,
@@ -20,12 +22,19 @@ def test_validate_purchase(
     assert has_errors is False
     assert order["error"] is None
 
+    has_errors, order = validate_terminate_order(
+        mpt_client,
+        processing_termination_order,
+    )
+
+    assert has_errors is False
+    assert order["error"] is None
+
 
 @pytest.mark.parametrize(
     "order",
     [
         "processing_change_order",
-        "processing_termination_order",
         "processing_configuration_order",
     ],
 )
@@ -43,20 +52,24 @@ def test_validate_other_orders(
     assert order["error"] == err_msg
 
 
-def test_validate_order_purchase(
+def test_validate_order(
     mpt_client,
     processing_purchase_order,
+    processing_termination_order,
 ):
     order = validate_order(mpt_client, processing_purchase_order)
 
     assert order["error"] is None
 
+    order = validate_order(mpt_client, processing_termination_order)
+
+    assert order["error"] is None
+
 
 @pytest.mark.parametrize(
     "order",
     [
         "processing_change_order",
-        "processing_termination_order",
         "processing_configuration_order",
     ],
 )