MPT-8098 Add draft validation for Purchase Order

Author: d3rky

ffc/flows/fulfillment.py

@@ -15,7 +15,9 @@
     CreateEmployee,
     CreateOrganization,
     CreateSubscription,
+    QueryIfInvalid,
     ResetDueDate,
+    ResetOrderErrors,
     SetupAgreementExternalId,
     SetupDueDate,
 )
@@ -25,9 +27,11 @@
 
 
 purchase = Pipeline(
+    ResetOrderErrors(),
     SetupDueDate(),
     CheckDueDate(),
     CheckOrderParameters(),
+    QueryIfInvalid(),
     CreateEmployee(),
     CreateOrganization(),
     SetupAgreementExternalId(),

ffc/flows/order.py

@@ -26,6 +26,7 @@ def is_purchase_order(order):
 @dataclass
 class OrderContext(BaseContext):
     order: dict
+    validation_succeeded: bool = True
     employee: dict = field(init=False, default=None)
     organization: dict = field(init=False, default=None)
 

ffc/flows/steps/__init__.py

@@ -3,6 +3,8 @@
 from ffc.flows.steps.order import (
     CheckOrderParameters,
     CompleteOrder,
+    QueryIfInvalid,
+    ResetOrderErrors,
     SetupAgreementExternalId,
 )
 from ffc.flows.steps.subscription import CreateSubscription
@@ -11,7 +13,9 @@
     "CompleteOrder",
     "CreateSubscription",
     "CheckDueDate",
+    "QueryIfInvalid",
     "ResetDueDate",
+    "ResetOrderErrors",
     "SetupDueDate",
     "CreateEmployee",
     "CreateOrganization",

ffc/flows/steps/order.py

@@ -14,12 +14,14 @@
     ERR_ORGANIZATION_NAME,
 )
 from ffc.flows.order import MPT_ORDER_STATUS_COMPLETED, MPT_ORDER_STATUS_QUERYING
+from ffc.flows.steps.utils import reset_order_error
 from ffc.notifications import send_email_notification
 from ffc.parameters import (
     PARAM_ADMIN_CONTACT,
     PARAM_CURRENCY,
     PARAM_ORGANIZATION_NAME,
     get_ordering_parameter,
+    reset_ordering_parameters_error,
     set_ordering_parameter_error,
 )
 
@@ -73,8 +75,8 @@ def __call__(self, client, context, next_step):
 
 class CheckOrderParameters(Step):
     """
-    Check if all required parameters are submitted, if not
-    query order
+    Check if all required parameters are submitted
+    If not sets `validation_succeeded` to False
     """
 
     def __call__(self, client, context, next_step):
@@ -84,7 +86,6 @@ def __call__(self, client, context, next_step):
             PARAM_ADMIN_CONTACT: ERR_ADMIN_CONTACT,
         }
         order = context.order
-        empty_parameters = []
 
         for param_name in [
             PARAM_ORGANIZATION_NAME,
@@ -96,9 +97,20 @@ def __call__(self, client, context, next_step):
                 order = set_ordering_parameter_error(
                     order, param_name, errors[param_name]
                 )
-                empty_parameters.append(param_name)
+                context.validation_succeeded = False
 
-        if empty_parameters:
+        next_step(client, context)
+
+
+class QueryIfInvalid(Step):
+    """
+    Check if `validation_succeeded` context parameter is True
+    If not - query order
+    """
+
+    def __call__(self, client, context, next_step):
+        order = context.order
+        if not context.validation_succeeded:
             template = get_product_template_or_default(
                 client,
                 context.product_id,
@@ -109,9 +121,22 @@ def __call__(self, client, context, next_step):
             order["agreement"] = agreement
             context.order = order
             logger.info(
-                f"{context}: parameters {', '.join(empty_parameters)} are empty, move to querying",
+                f"{context}: ordering parameters are invalid, move to querying",
             )
             send_email_notification(client, order)
             return
 
         next_step(client, context)
+
+
+class ResetOrderErrors(Step):
+    """
+    Reset order errors and parameter errors. Is used before processing
+    to not to show errors during procesing or after validation is succeseed
+    """
+
+    def __call__(self, client, context, next_step):
+        context.order = reset_order_error(context.order)
+        context.order = reset_ordering_parameters_error(context.order)
+
+        next_step(client, context)

ffc/flows/steps/utils.py

@@ -1,3 +1,5 @@
+from copy import deepcopy
+
 from swo.mpt.client.mpt import fail_order
 
 from ffc.notifications import send_email_notification
@@ -24,3 +26,9 @@ def switch_order_to_failed(client, order, status_notes):
     order["agreement"] = agreement
     send_email_notification(client, order)
     return order
+
+
+def reset_order_error(order):
+    updated_order = deepcopy(order)
+    updated_order["error"] = None
+    return updated_order

ffc/flows/validation/base.py ffc/flows/validation.pyffc/flows/validation/base.py renamed to ffc/flows/validation.py

@@ -1,8 +1,11 @@
 import logging
 import traceback
 
+from swo.mpt.extensions.flows.pipeline import Pipeline
+
 from ffc.flows.error import strip_trace_id
-from ffc.flows.order import is_purchase_order
+from ffc.flows.order import OrderContext, is_purchase_order
+from ffc.flows.steps.order import CheckOrderParameters
 from ffc.notifications import notify_unhandled_exception_in_teams
 
 logger = logging.getLogger(__name__)
@@ -23,7 +26,7 @@ def validate_order(client, order):
         has_errors = False
 
         if is_purchase_order(order):
-            pass
+            has_errors, order = validate_purchase_order(client, order)
 
         logger.info(
             f"Validation of order {order['id']} succeeded "
@@ -37,3 +40,12 @@ def validate_order(client, order):
             strip_trace_id(traceback.format_exc()),
         )
         raise
+
+
+def validate_purchase_order(client, order):
+    pipeline = Pipeline(
+        CheckOrderParameters(),
+    )
+    context = OrderContext(order=order)
+    pipeline.run(client, context)
+    return not context.validation_succeeded, context.order

ffc/flows/validation/__init__.py

@@ -93,3 +93,21 @@ def set_due_date(order, due_date):
     param["value"] = due_date
 
     return updated_order
+
+
+def reset_ordering_parameters_error(order):
+    """
+    Reset errors for all ordering parameters
+
+    Args:
+        order (dict): The order that contains the parameter.
+
+    Returns:
+        dict: The order updated.
+    """
+    updated_order = copy.deepcopy(order)
+
+    for param in updated_order["parameters"][PARAM_PHASE_ORDERING]:
+        param["error"] = None
+
+    return updated_order

ffc/parameters.py

@@ -87,6 +87,7 @@ filterwarnings = [
 
 [tool.coverage.run]
 branch = true
+relative_files = true
 
 [tool.ruff]
 extend-exclude = [".vscode", ".devcontainer", "swo"]

pyproject.toml

@@ -529,6 +529,17 @@ def querying_purchase_order(order_factory):
     return order_factory(status="Querying")
 
 
+@pytest.fixture()
+def draft_purchase_valid_order(order_factory):
+    return order_factory(status="Draft")
+
+
+@pytest.fixture()
+def draft_purchase_invalid_order(draft_purchase_valid_order):
+    draft_purchase_valid_order["parameters"]["ordering"][0]["value"] = None
+    return draft_purchase_valid_order
+
+
 @pytest.fixture()
 def webhook(settings):
     return {