Skip to content

Commit 36ff30a

Browse files
committed
fix: improve Dockerfile, Makefile, README and compose.yaml
1 parent 75e4f2b commit 36ff30a

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM ghcr.io/astral-sh/uv:python3.12-bookworm-slim AS base
22

3-
COPY pyproject.toml uv.lock ./mpt_tool/
3+
COPY pyproject.toml uv.lock README.md ./mpt_tool/
44

55
WORKDIR /mpt_tool
66

@@ -11,10 +11,10 @@ ENV PATH=/opt/venv/bin:$PATH
1111

1212
FROM base AS build
1313

14-
COPY . .
15-
1614
RUN uv sync --frozen --no-cache --all-groups --active
1715

16+
COPY . .
17+
1818
FROM build AS dev
1919

2020
CMD ["bash"]

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Common development workflows are wrapped in the `makefile`:
2424
- `make bash` – start the app container and open a bash shell
2525
- `make build` – build the application image for development
2626
- `make check` – run code quality checks (ruff, flake8, lockfile check)
27-
- `make check-all` – run checks, formatting, and tests
27+
- `make check-all` – run checks and tests
2828
- `make format` – apply formatting and import fixes
2929
- `make down` – stop and remove containers
3030
- `make review` – check the code in the cli by running CodeRabbit

compose.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
services:
22
app:
3-
container_name: mpt_tool
43
build:
54
context: .
65
target: dev

makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ help:
77
@echo " make bash - Open a bash shell in the app container."
88
@echo " make build - Build images."
99
@echo " make check - Check code quality with ruff."
10-
@echo " make check-all - Run check and tests."
10+
@echo " make check-all - Run checks and tests."
1111
@echo " make down - Stop and remove containers."
1212
@echo " make format - Format code."
1313
@echo " make review - Check the code in the cli by running CodeRabbit."
@@ -41,4 +41,4 @@ run:
4141
$(DC) run --rm -it app bash -c "mpt-tool --help && exec bash"
4242

4343
test:
44-
$(DC) run --rm app pytest $(args) .
44+
$(DC) run --rm app pytest $(if $(args),$(args),.)

0 commit comments

Comments
 (0)