MPT-17825: resolve WPS5XX violations (#153)

🤖 **Codex-generated PR** — Please review carefully.

## Summary
- resolve WPS5XX issues in source code for control-flow and style
patterns
- update logic in console, errors, handlers, stats, apps, and audit
plugin for wemake compliance
- remove `WPS504,WPS518,WPS519,WPS529` from flake8 per-file ignores in
`pyproject.toml`

## Validation
- `make check-all`


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
Closes [MPT-17825](https://softwareone.atlassian.net/browse/MPT-17825)

## Release Notes

- **cli/core/console.py**: Refactored per-character styling to build
Text pieces via indexed iteration and Text.assemble instead of in-place
char.stylize.
- **cli/core/errors.py**: Consolidated HTTP error handling in
`wrap_http_error`; added `_parse_bad_request_message(response)` to
extract BAD_REQUEST JSON errors with graceful fallbacks.
- **cli/core/handlers/errors.py**: Simplified
`ExcelFileHandlerError.__init__` to default message/details cleanly and
copy details into a new list when provided.
- **cli/core/handlers/excel_file_handler.py**: Inverted
`_clean_worksheets` logic to clear the entire cache when no sheet is
specified and remove a specific sheet when provided.
- **cli/core/nested_dicts.py**: Simplified nested path setting control
flow; base-case returns after dict.update and intermediate non-dict
values are treated as missing/overwritten.
- **cli/core/products/app.py**: Minor refactor of `out_path` assignment
to use an explicit None check (behavior unchanged).
- **cli/core/products/models/template.py**: Reordered None-check in
`to_xlsx` default handling (behavior unchanged).
- **cli/core/stats.py**: Made `ErrorMessagesCollector.__str__` robust to
missing empty-key sections by using `section.get("", [])` and
conditional appending.
- **cli/plugins/audit_plugin/app.py**: Inverted conditional used to
display Source/Target Value columns so missing values show red
"<missing>" consistently.
- **pyproject.toml**: Removed per-file flake8 ignores for WPS518,
WPS519, and WPS529 to align with wemake-python-styleguide WPS5XX rules.
- **Tests**: Added/updated tests covering error wrapping, Excel file
handler cache behavior, nested dict overwriting, and
ExcelFileHandlerError detail copying.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

[MPT-17825]:
https://softwareone.atlassian.net/browse/MPT-17825?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Author: d3rky

cli/core/console.py

@@ -43,10 +43,8 @@ def show_banner() -> None:
 
     for line in banner_lines:
         colored_line = Text()
-        for index in range(len(line)):
-            char = line[index : index + 1]
-            char.stylize(colors[index])
-            colored_line = Text.assemble(colored_line, char)
+        for index, char in enumerate(line.plain):
+            colored_line = Text.assemble(colored_line, Text(char, style=colors[index]))
         console.print(colored_line)
 
 

cli/core/errors.py

@@ -4,7 +4,7 @@
 from typing import ParamSpec, TypeVar
 
 from mpt_api_client.exceptions import MPTHttpError as APIException
-from requests import RequestException
+from requests import RequestException, Response
 
 CallableParams = ParamSpec("CallableParams")
 RetType = TypeVar("RetType")
@@ -25,7 +25,27 @@ def __str__(self) -> str:
         return f"{self._request_msg} with response body {self._response_body}"
 
 
-def wrap_http_error[**CallableParams, RetType](  # noqa: C901
+def _parse_bad_request_message(response: Response) -> str:
+    try:
+        response_body = response.json()
+    except ValueError:
+        return str(response.content)
+
+    response_errors = response_body.get("errors", {}) if isinstance(response_body, dict) else {}
+    if not isinstance(response_errors, dict) or not response_errors:
+        return str(response.content)
+
+    return "\n".join(
+        (
+            f"{field}: {error_details[0]}"
+            if isinstance(error_details, (list, tuple)) and error_details
+            else f"{field}: {error_details}"
+        )
+        for field, error_details in response_errors.items()
+    )
+
+
+def wrap_http_error[**CallableParams, RetType](
     func: Callable[CallableParams, RetType],
 ) -> Callable[CallableParams, RetType]:
     """Decorator to wrap HTTP request functions and handle RequestException.
@@ -45,18 +65,13 @@ def _wrapper(*args: CallableParams.args, **kwargs: CallableParams.kwargs) -> Ret
         except RequestException as error:
             if error.response is None:
                 msg = "No response"
-            elif error.response.status_code == HTTPStatus.BAD_REQUEST:
-                response_body = error.response.json()
-
-                msg = ""
-                if "errors" in response_body:
-                    for field, error_details in response_body["errors"].items():
-                        msg += f"{field}: {error_details[0]}\n"
-                else:
-                    msg = str(error.response.content)
-            else:
+                raise MPTAPIError(str(error), msg) from error
+
+            if error.response.status_code != HTTPStatus.BAD_REQUEST:
                 msg = str(error.response.content)
+                raise MPTAPIError(str(error), msg) from error
 
+            msg = _parse_bad_request_message(error.response)
             raise MPTAPIError(str(error), msg) from error
 
     return _wrapper

cli/core/handlers/errors.py

@@ -4,8 +4,8 @@ class ExcelFileHandlerError(Exception):
     _default_message = "Excel file handler error"
 
     def __init__(self, message: str | None = None, details: list | None = None):
-        self.message = message if message is not None else self._default_message
-        self.details = details if details is not None else []
+        self.message = self._default_message if message is None else message
+        self.details = [] if details is None else list(details)
 
 
 class RequiredSheetsError(ExcelFileHandlerError):

cli/core/handlers/excel_file_handler.py

@@ -335,10 +335,11 @@ def write_cell(
         sheet[coordinate] = cell_value
 
     def _clean_worksheets(self, sheet_name: str | None = None) -> None:
-        if sheet_name is not None:
-            self._worksheets_cache.pop(sheet_name, None)
-        else:
+        if sheet_name is None:
             self._worksheets_cache = {}
+            return
+
+        self._worksheets_cache.pop(sheet_name, None)
 
     def _get_fields_from_horizontal_worksheet(self, worksheet_name: str, max_row: int) -> list[str]:
         return list(

cli/core/nested_dicts.py

@@ -15,12 +15,15 @@ def set_dict_value(original_dict: dict[str, Any], path: str, new_value: Any) ->
     """
     path_list = path.split(".", 1)
     if len(path_list) == 1:
-        original_dict[path_list[0]] = new_value
+        original_dict.update({path_list[0]: new_value})
+        return original_dict
+
+    current, next_path = path_list[0], path_list[-1]
+    if current in original_dict:
+        current_value = original_dict.get(current)
+        next_dict = current_value if isinstance(current_value, dict) else {}
     else:
-        current, next_path = path_list[0], path_list[-1]
-        if current in original_dict:
-            original_dict[current] = set_dict_value(original_dict[current], next_path, new_value)
-        else:
-            original_dict[current] = set_dict_value({}, next_path, new_value)
+        next_dict = {}
 
+    original_dict.update({current: set_dict_value(next_dict, next_path, new_value)})
     return original_dict

cli/core/price_lists/app.py

@@ -141,7 +141,7 @@ def export(  # noqa: C901
         )
         raise typer.Exit(code=4)
 
-    out_path = out_path if out_path is not None else str(Path.cwd())
+    out_path = str(Path.cwd()) if out_path is None else out_path
     mpt_client = create_api_mpt_client_from_account(active_account)
     stats = PriceListStatsCollector()
     has_error = False

cli/core/products/app.py

@@ -51,7 +51,7 @@ def export(  # noqa: C901
         )
         raise typer.Exit(code=4)
 
-    out_path = out_path if out_path is not None else str(Path.cwd())
+    out_path = str(Path.cwd()) if out_path is None else out_path
     has_error = False
     for product_id in product_ids:
         file_path = Path(out_path) / f"{product_id}.xlsx"

cli/core/products/models/template.py

@@ -69,7 +69,7 @@ def to_xlsx(self) -> dict[str, Any]:
             constants.TEMPLATES_NAME: self.name,
             constants.TEMPLATES_ACTION: self.action,
             constants.TEMPLATES_TYPE: self.type,
-            constants.TEMPLATES_DEFAULT: str(self.default) if self.default is not None else None,
+            constants.TEMPLATES_DEFAULT: None if self.default is None else str(self.default),
             constants.TEMPLATES_CONTENT: self.template_content,
             constants.TEMPLATES_CREATED: self.created_date,
             constants.TEMPLATES_MODIFIED: self.updated_date,

cli/core/stats.py

@@ -70,8 +70,9 @@ def __str__(self) -> str:
         msg = ""
         for section_name, section in self._sections.items():
             msg = f"{msg}{section_name}:"
-            if "" in section:
-                msg = f"{msg} {', '.join(section[''])}\n"
+            section_messages = section.get("", [])
+            if section_messages:
+                msg = f"{msg} {', '.join(section_messages)}\n"
             else:
                 msg += "\n"
 

cli/plugins/audit_plugin/app.py

@@ -58,8 +58,8 @@ def compare_audit_trails(source_trail: dict[str, Any], target_trail: dict[str, A
             formatted_path = format_json_path(key, source_trail, target_trail)
             table.add_row(
                 formatted_path,
-                str(source_value) if source_value is not None else "[red]<missing>[/red]",
-                str(target_value) if target_value is not None else "[red]<missing>[/red]",
+                "[red]<missing>[/red]" if source_value is None else str(source_value),
+                "[red]<missing>[/red]" if target_value is None else str(target_value),
             )
 
     if differences_found: