refactor: resolve WPS210, WPS221, WPS229, WPS231 violations

Author: svazquezco

cli/core/accounts/app.py

@@ -161,10 +161,11 @@ def get_active_account() -> Account:
 
     try:
         account = find_active_account(accounts)
-        console.print(f"Current active account: {account.id} ({account.name})")
     except NoActiveAccountFoundError as error:
         console.print(str(error))
         raise typer.Exit(code=3)
+    else:
+        console.print(f"Current active account: {account.id} ({account.name})")
 
     return account
 

cli/core/handlers/horizontal_tab_file_manager.py

@@ -82,8 +82,7 @@ def write_error(self, error: str, resource_id: str | None = None) -> None:
             if row[self._id_field]["value"] == resource_id
         )
         try:
-            coordinate = item_row[ERROR_COLUMN_NAME]["coordinate"]
-            column_letter, row_number = self._get_row_and_column_from_coordinate(coordinate)
+            column_letter, row_number = self._resolve_error_cell_position(item_row)
         except (KeyError, ValueError):
             column_letter = self.file_handler.get_sheet_next_column(self._sheet_name)
             coordinate = next(iter(item_row.values()))["coordinate"]
@@ -92,13 +91,15 @@ def write_error(self, error: str, resource_id: str | None = None) -> None:
 
         self.file_handler.write([{self._sheet_name: {f"{column_letter}{row_number}": error}}])
 
+    def _get_currency_and_precision(self, record: DataModel) -> tuple[str | None, int | None]:
+        return record.currency, record.precision  # type: ignore[attr-defined]
+
     def _get_style(self, record: DataModel, cell_value: Any) -> NamedStyle | None:
         if not isinstance(cell_value, float):
             return None
 
         try:
-            currency = record.currency  # type: ignore[attr-defined]
-            precision = record.precision  # type: ignore[attr-defined]
+            currency, precision = self._get_currency_and_precision(record)
         except AttributeError:
             return None
 
@@ -107,6 +108,10 @@ def _get_style(self, record: DataModel, cell_value: Any) -> NamedStyle | None:
 
         return get_number_format_style(currency, precision)
 
+    def _resolve_error_cell_position(self, item_row: dict[str, Any]) -> tuple[str, int]:
+        coordinate = item_row[ERROR_COLUMN_NAME]["coordinate"]
+        return self._get_row_and_column_from_coordinate(coordinate)
+
     @abstractmethod
     def _read_data(self) -> Generator[dict[str, Any], None, None]:
         raise NotImplementedError

cli/core/mpt/client.py

@@ -76,7 +76,7 @@ def join_url(self, url: str) -> str:
             The full URL as a string.
 
         """
-        url = url[1:] if url and url[0] == "/" else url
+        url = url.removeprefix("/")
         return urljoin(self.base_url, url, allow_fragments=True)
 
 

cli/core/price_lists/services/item_service.py

@@ -25,8 +25,9 @@ def export(self) -> ServiceResult:
         limit = 100
         select = "audit,item.terms,priceList.precision,priceList.currency"
         while True:
+            query_params = {"select": select, "offset": offset, "limit": limit}
             try:
-                response = self.api.list({"select": select, "offset": offset, "limit": limit})
+                response = self.api.list(query_params)
             except MPTAPIError as error:
                 self.stats.add_error(TAB_PRICE_ITEMS)
                 return ServiceResult(
@@ -62,14 +63,14 @@ def retrieve_from_mpt(self, resource_id: str) -> ServiceResult:
 
     @override
     def update(self) -> ServiceResult:
-        errors = []
+        errors: list[str] = []
         for record in self.file_manager.read_data():
             if not record.to_update():
                 self._set_skipped()
                 continue
 
+            query_params = {"item.ExternalIds.vendor": record.vendor_id, "limit": 1}
             try:
-                query_params = {"item.ExternalIds.vendor": record.vendor_id, "limit": 1}
                 item_data = self.api.list(query_params=query_params)["data"][0]
             except MPTAPIError as error:
                 errors.append(str(error))
@@ -80,8 +81,10 @@ def update(self) -> ServiceResult:
             record.type = "operations" if self.account.is_operations() else "vendor"
             try:
                 self.api.update(item_data["id"], record.to_json())
-                self._set_synced(record.id, record.coordinate)
             except MPTAPIError as error:
                 errors.append(f"Item {record.id}: {error!s}")
                 self._set_error(str(error), record.id)
-        return ServiceResult(success=len(errors) == 0, errors=errors, model=None, stats=self.stats)
+                continue
+
+            self._set_synced(record.id, record.coordinate)
+        return ServiceResult(success=not errors, errors=errors, model=None, stats=self.stats)

cli/core/products/services/related_components_base_service.py

@@ -108,7 +108,7 @@ def update(self) -> ServiceResult:
 
             self._set_synced(data_model.id, data_model.coordinate)
 
-        return ServiceResult(success=len(errors) == 0, errors=errors, model=None, stats=self.stats)
+        return ServiceResult(success=not errors, errors=errors, model=None, stats=self.stats)
 
     def prepare_data_model_to_create(self, data_model: DataModel) -> DataModel:
         """Hook method to customize the data model before creating it.

cli/plugins/audit_plugin/api.py

@@ -11,13 +11,15 @@ def get_audit_trail(client: Any, record_id: str) -> dict[str, Any]:
 
     try:
         response = client.get(f"{endpoint}?{query_string}")
-        return response.json()
+        response_payload = response.json()
     except Exception as error:
         console.print(
             f"[red]Failed to retrieve audit trail for record {record_id}: {error!s}[/red]"
         )
         raise typer.Exit(1)
 
+    return response_payload
+
 
 def get_audit_records_by_object(
     client: Any, object_id: str, limit: int = 10
@@ -31,14 +33,16 @@ def get_audit_records_by_object(
 
     try:
         response = client.get(f"{endpoint}?{query_string}")
-        records = response.json().get("data", [])
-        if not records:
-            console.print(f"[red]No audit records found for object {object_id}[/red]")
-            raise typer.Exit(1)  # noqa: TRY301
+        response_payload = response.json()
     except Exception as error:
         console.print(
             f"[red]Failed to retrieve audit records for object {object_id}: {error!s}[/red]"
         )
         raise typer.Exit(1)
 
+    records = response_payload.get("data", [])
+    if not records:
+        console.print(f"[red]No audit records found for object {object_id}[/red]")
+        raise typer.Exit(1)
+
     return records